Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split-large-code-file-functions #13592

Conversation

Shyam-Raghuwanshi
Copy link
Contributor

What does this PR do?
this PR Identify and Split the Large Code Files

Fixes #12559

Copy link

vercel bot commented Feb 8, 2024

@Shyam-Raghuwanshi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added automated-tests area: unit tests, e2e tests, playwright Low priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack 💻 refactor 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 8, 2024
@Shyam-Raghuwanshi Shyam-Raghuwanshi changed the title Split large code file functions feat: Split-large-code-file-functions Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v3.9 milestone Feb 8, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Feb 8, 2024
@keithwillcode keithwillcode requested a review from a team February 8, 2024 10:34
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to introduce a new modules folder right now. Let's just keep these new files in packages/features/bookings/lib and we can reassess a new file structure and architecture later.

Also, the function getAllCredentials was ok as a name when it lived in handleNewBooking.ts but now as a standalone function doesn't make sense. getAllCredentials with no context makes the user of said function think it will literally get all credentials.

Let's rename it to something like `getAllCredentialsForUsersOnEvent'.

@keithwillcode keithwillcode marked this pull request as draft February 14, 2024 13:47
@keithwillcode keithwillcode requested a review from a team February 14, 2024 13:47
@Shyam-Raghuwanshi Shyam-Raghuwanshi marked this pull request as ready for review February 15, 2024 09:59
@keithwillcode keithwillcode merged commit 477e102 into calcom:main Feb 16, 2024
29 of 37 checks passed
@Shyam-Raghuwanshi Shyam-Raghuwanshi deleted the feat/Identify-and-Split-Large-Code-Files branch February 16, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync osshack Submission for 2023 OSShack 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2766] Refactor: Identify and Split Large Code Files for Improved Testability
2 participants