-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Split-large-code-file-functions #13592
feat: Split-large-code-file-functions #13592
Conversation
@Shyam-Raghuwanshi is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to introduce a new modules folder right now. Let's just keep these new files in packages/features/bookings/lib
and we can reassess a new file structure and architecture later.
Also, the function getAllCredentials
was ok as a name when it lived in handleNewBooking.ts
but now as a standalone function doesn't make sense. getAllCredentials
with no context makes the user of said function think it will literally get all credentials.
Let's rename it to something like `getAllCredentialsForUsersOnEvent'.
What does this PR do?
this PR Identify and Split the Large Code Files
Fixes #12559