Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: organizer_default_conferencing_app translatable key in app location #13614

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Feb 9, 2024

What does this PR do?

Fixes #13547

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

linear bot commented Feb 9, 2024

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 9:54am
api 🔄 Building (Inspect) Visit Preview Feb 9, 2024 9:54am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 9, 2024 9:54am
cal-demo ⬜️ Ignored (Inspect) Feb 9, 2024 9:54am
calcom-web-canary ⬜️ Ignored (Inspect) Feb 9, 2024 9:54am
ui ⬜️ Ignored (Inspect) Feb 9, 2024 9:54am

@ThyMinimalDev ThyMinimalDev requested a review from a team February 9, 2024 09:52
@github-actions github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email foundation High priority Created by Linear-GitHub Sync labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@PeerRich PeerRich enabled auto-merge (squash) February 9, 2024 10:00
Copy link
Contributor

github-actions bot commented Feb 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 9, 2024

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/09/2024 10:11:36am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1d2d467

Started: 02/09/2024 10:02:36am UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email required and Phone required
Retry 1Initial Attempt
0% (0) 0 / 309 runs
failed over last 7 days
5.83% (18) 18 / 309 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Long Text required and Number not required
Retry 1Initial Attempt
0.32% (1) 1 / 315 run
failed over last 7 days
6.98% (22) 22 / 315 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
4.49% (14) 14 / 312 runs
failed over last 7 days
38.46% (120) 120 / 312 runs
flaked over last 7 days
Login and logout tests -- legacy Login flow validations -- future Should warn when user does not exist
Retry 2Retry 1Initial Attempt
0% (0) 0 / 312 runs
failed over last 7 days
1.92% (6) 6 / 312 runs
flaked over last 7 days

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking page with no questions Booking page with 640x480 resolution
Retry 1Initial Attempt
0% (0) 0 / 306 runs
failed over last 7 days
5.88% (18) 18 / 306 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and multiselect Question Address required and multiselect text required
Retry 1Initial Attempt
0% (0) 0 / 326 runs
failed over last 7 days
7.98% (26) 26 / 326 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address required and Radio group required
Retry 1Initial Attempt
0.31% (1) 1 / 325 run
failed over last 7 days
3.69% (12) 12 / 325 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Short text question Address required and Short text required
Retry 1Initial Attempt
0.61% (2) 2 / 326 runs
failed over last 7 days
4.29% (14) 14 / 326 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and select Question Radio required and select required
Retry 1Initial Attempt
0% (0) 0 / 311 runs
failed over last 7 days
6.43% (20) 20 / 311 runs
flaked over last 7 days

📄   apps/web/playwright/impersonation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1Initial Attempt
0.30% (1) 1 / 337 run
failed over last 7 days
9.50% (32) 32 / 337 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation
Retry 1Initial Attempt
14.20% (46) 46 / 324 runs
failed over last 7 days
11.42% (37) 37 / 324 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 1Initial Attempt
13.04% (42) 42 / 322 runs
failed over last 7 days
9.01% (29) 29 / 322 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
16.87% (14) 14 / 83 runs
failed over last 7 days
54.22% (45) 45 / 83 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-0.30% (-1) -1 / 330 runs
failed over last 7 days
52.42% (173) 173 / 330 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-110.19% (-173) -173 / 157 runs
failed over last 7 days
110.19% (173) 173 / 157 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-105.10% (-165) -165 / 157 runs
failed over last 7 days
105.73% (166) 166 / 157 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-106.41% (-166) -166 / 156 runs
failed over last 7 days
106.41% (166) 166 / 156 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-106.41% (-166) -166 / 156 runs
failed over last 7 days
106.41% (166) 166 / 156 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-105.77% (-165) -165 / 156 runs
failed over last 7 days
105.77% (165) 165 / 156 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-105.77% (-165) -165 / 156 runs
failed over last 7 days
105.77% (165) 165 / 156 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-105.77% (-165) -165 / 156 runs
failed over last 7 days
105.77% (165) 165 / 156 runs
flaked over last 7 days

📄   apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1Initial Attempt
0.91% (3) 3 / 331 runs
failed over last 7 days
9.37% (31) 31 / 331 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit 092cb0f into main Feb 9, 2024
40 checks passed
@PeerRich PeerRich deleted the morgan/cal-3080-location-not-shown-correctly-in-email-for-location-changed branch February 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email foundation High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3080] Location not shown correctly in email for location changed
3 participants