Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ooo-v2 #13621

Merged
merged 76 commits into from Apr 10, 2024
Merged

feat: ooo-v2 #13621

merged 76 commits into from Apr 10, 2024

Conversation

alannnc
Copy link
Contributor

@alannnc alannnc commented Feb 9, 2024

What does this PR do?

  • Removes old feature that triggered a profile forwarding.
  • New feature allows to view current user calendar with out of office days distinction and a Click to Action if forwarded.
  • Revamps Out of office from settings
  • Adds reasons and a emoji to out of office entries
  • New reasons table with seeded for default options

Fixes #13558

Loom Video: https://www.loom.com/share/2c906d2c73ba4e4aabee4cc77b6b3d23?sid=5327dc00-c8c2-40ae-98e6-ac96f8e4c9fc

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Are there environment variables that should be set? None
  • What are the minimal test data to have? 2 users in a team with events
  • What is expected (happy path) to have (input and output)? One user can mark days OOO with/without forward to team member.
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

Copy link

vercel bot commented Feb 9, 2024

@alannnc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 410.87 KB 639.21 KB 182.63% (🟡 +0.29%)
/[user]/[type]/embed 410.88 KB 639.21 KB 182.63% (🟡 +0.29%)
/apps/[slug]/[...pages] 585.16 KB 813.49 KB 232.43% (🟡 +0.25%)
/availability/troubleshoot 202.06 KB 430.39 KB 122.97% (🟡 +0.27%)
/d/[link]/[slug] 410.69 KB 639.02 KB 182.58% (🟡 +0.28%)
/event-types 554.77 KB 783.11 KB 223.74% (🟡 +0.26%)
/event-types/[type] 433.71 KB 662.04 KB 189.16% (🟡 +0.25%)
/org/[orgSlug]/[user]/[type] 411.08 KB 639.42 KB 182.69% (🟡 +0.29%)
/org/[orgSlug]/[user]/[type]/embed 411.11 KB 639.44 KB 182.70% (🟡 +0.28%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 410.7 KB 639.04 KB 182.58% (🟡 +0.29%)
/org/[orgSlug]/team/[slug]/[type] 410.9 KB 639.23 KB 182.64% (🟡 +0.28%)
/settings/my-account/out-of-office 266.23 KB 494.57 KB 141.30% (🟡 +0.26%)
/team/[slug]/[type] 410.87 KB 639.2 KB 182.63% (🟡 +0.28%)
/team/[slug]/[type]/embed 410.89 KB 639.23 KB 182.64% (🟡 +0.28%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode added community Created by Linear-GitHub Sync and removed 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Feb 9, 2024
@keithwillcode keithwillcode added this to the v3.9 milestone Feb 9, 2024
@keithwillcode keithwillcode requested a review from a team February 9, 2024 21:27
@github-actions github-actions bot added 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Feb 10, 2024
@github-actions github-actions bot added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 8, 2024
CarinaWolli
CarinaWolli previously approved these changes Apr 8, 2024
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I change my working hours after I already have an OOO created, OOO stops working and is shown as available: OOO - availability bug

Fixed with c04f8ec, tested an works now 🙏

@CarinaWolli CarinaWolli dismissed stale reviews from zomars and themself via 5ec48e7 April 9, 2024 13:10
CarinaWolli
CarinaWolli previously approved these changes Apr 9, 2024
@PeerRich PeerRich removed the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 9, 2024
@github-actions github-actions bot added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 9, 2024
@CarinaWolli
Copy link
Member

@zomars do you know why e2e tests keep failing?

@zomars
Copy link
Member

zomars commented Apr 9, 2024

@zomars do you know why e2e tests keep failing?

Currently investigating. It is consistently failing but I don't see an obvious cause. I don't think it's directly related to this PR. which is odd.

@alannnc
Copy link
Contributor Author

alannnc commented Apr 9, 2024

@zomars do you know why e2e tests keep failing?

Currently investigating. It is consistently failing but I don't see an obvious cause. I don't think it's directly related to this PR. which is odd.

It's happening on other PRs as well? Do we have artifacts to look at? @zomars

@zomars
Copy link
Member

zomars commented Apr 9, 2024

@zomars do you know why e2e tests keep failing?

Currently investigating. It is consistently failing but I don't see an obvious cause. I don't think it's directly related to this PR. which is odd.

It's happening on other PRs as well? Do we have artifacts to look at? @zomars

You should be able to download them at the bottom of the results page:

https://github.com/calcom/cal.com/actions/runs/8621332198?pr=13621

@zomars
Copy link
Member

zomars commented Apr 9, 2024

Found the issue. Will PR a patch soon.

@zomars zomars merged commit 880ba8f into calcom:main Apr 10, 2024
30 of 38 checks passed
@dosubot dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request high-risk Requires approval by Foundation team 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3083] Out of office (OOO) v2
6 participants