Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oncancel modal action week layout #13625

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

alannnc
Copy link
Contributor

@alannnc alannnc commented Feb 9, 2024

What does this PR do?

When in week layout after you've selected a slot and then click on the Back button to remove the modal the page crashes as it tries to resolve dayjs(null).

Fixes #
https://www.loom.com/share/96348c529d7944108144e6f7f7c6644e

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Feb 9, 2024

@alannnc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode requested a review from a team February 9, 2024 22:58
@keithwillcode keithwillcode added ui area: UI, frontend, button, form, input community Created by Linear-GitHub Sync consumer High priority Created by Linear-GitHub Sync labels Feb 9, 2024
@keithwillcode keithwillcode added this to the v3.8 milestone Feb 9, 2024
@zomars zomars added the 🐛 bug Something isn't working label Feb 9, 2024
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars enabled auto-merge (squash) February 9, 2024 22:59
@zomars zomars merged commit b183a57 into calcom:main Feb 9, 2024
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer High priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants