feat: added banner for orgs #13644

PeerRich · 2024-02-12T14:56:57Z

Use this banner to test https://pbs.twimg.com/profile_banners/1063089191565905920/1685635865/1500x500

add backend
add file upload (require 1500x500px) in Organization/Appearance
for now, apply this to all Org event types. later we could think about sub-team overwrites, but for now org is enough

Upload Banner Screen

Go to Org Team Event Types

DESIGNS

__

mobile:

linear · 2024-02-12T14:57:00Z

CAL-3120 add a banner to org links

vercel · 2024-02-12T14:57:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2024 1:34pm
api	🔄 Building (Inspect)	Visit Preview		Mar 5, 2024 1:34pm

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Mar 5, 2024 1:34pm
cal-demo	⬜️ Ignored (Inspect)		Mar 5, 2024 1:34pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Mar 5, 2024 1:34pm
qa	⬜️ Ignored (Inspect)	Visit Preview	Mar 5, 2024 1:34pm
ui	⬜️ Ignored (Inspect)	Visit Preview	Mar 5, 2024 1:34pm

github-actions · 2024-02-12T14:57:11Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions · 2024-02-12T15:06:47Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/organizations/profile`	`400.06 KB`	588.43 KB	168.12% (🟡 +0.16%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2024-02-12T15:06:57Z

Current Playwright Test Results Summary

✅ 286 Passing - ⚠️ 26 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/05/2024 01:46:18pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: da2440b

Started: 03/05/2024 01:42:34pm UTC

⚠️ Flakes

📄 apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

`null`	13 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.02% (-17) -17 / 212 runs failed over last 7 days	8.49% (18) 18 / 212 runs flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.53% (-18) -18 / 211 runs failed over last 7 days	8.53% (18) 18 / 211 runs flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.53% (-18) -18 / 211 runs failed over last 7 days	8.53% (18) 18 / 211 runs flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.06% (-17) -17 / 211 runs failed over last 7 days	8.53% (18) 18 / 211 runs flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.57% (-18) -18 / 210 runs failed over last 7 days	8.57% (18) 18 / 210 runs flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.57% (-18) -18 / 210 runs failed over last 7 days	8.57% (18) 18 / 210 runs flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.57% (-18) -18 / 210 runs failed over last 7 days	8.57% (18) 18 / 210 runs flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes Retry 1 • Initial Attempt	-8.57% (-18) -18 / 210 runs failed over last 7 days	8.57% (18) 18 / 210 runs flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes Retry 1 • Initial Attempt	-7.62% (-16) -16 / 210 runs failed over last 7 days	8.57% (18) 18 / 210 runs flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes Retry 1 • Initial Attempt	-8.65% (-18) -18 / 208 runs failed over last 7 days	8.65% (18) 18 / 208 runs flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-8.65% (-18) -18 / 208 runs failed over last 7 days	8.65% (18) 18 / 208 runs flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes Retry 1 • Initial Attempt	-5.77% (-12) -12 / 208 runs failed over last 7 days	8.65% (18) 18 / 208 runs flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes Retry 1 • Initial Attempt	-4.46% (-9) -9 / 202 runs failed over last 7 days	8.91% (18) 18 / 202 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 3 Flakes

Top 1 Common Error Messages

`null`	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address Retry 1 • Initial Attempt	2.27% (5) 5 / 220 runs failed over last 7 days	13.64% (30) 30 / 220 runs flaked over last 7 days
Event Types tests -- future user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present Retry 1 • Initial Attempt	0.47% (1) 1 / 215 run failed over last 7 days	3.26% (7) 7 / 215 runs flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	1.40% (3) 3 / 214 runs failed over last 7 days	14.95% (32) 32 / 214 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail Team invitation Retry 1 • Initial Attempt	0.88% (2) 2 / 226 runs failed over last 7 days	11.06% (25) 25 / 226 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

`null`	8 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	-0.45% (-1) -1 / 224 runs failed over last 7 days	46.88% (105) 105 / 224 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-87.50% (-105) -105 / 120 runs failed over last 7 days	87.50% (105) 105 / 120 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-88.14% (-104) -104 / 118 runs failed over last 7 days	88.14% (104) 104 / 118 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-88.03% (-103) -103 / 117 runs failed over last 7 days	88.03% (103) 103 / 117 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-86.44% (-102) -102 / 118 runs failed over last 7 days	87.29% (103) 103 / 118 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-88.03% (-103) -103 / 117 runs failed over last 7 days	88.03% (103) 103 / 117 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-88.03% (-103) -103 / 117 runs failed over last 7 days	88.03% (103) 103 / 117 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-88.03% (-103) -103 / 117 runs failed over last 7 days	88.03% (103) 103 / 117 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme Retry 1 • Initial Attempt	0% (0) 0 / 223 runs failed over last 7 days	47.98% (107) 107 / 223 runs flaked over last 7 days

View Detailed Build Results

keithwillcode · 2024-02-13T05:29:02Z

Moving back to draft since backend needs to be built

zomars · 2024-02-15T21:58:08Z

packages/prisma/schema.prisma

@@ -341,6 +341,7 @@ model Team {
  brandColor           String?
  darkBrandColor       String?
  verifiedNumbers      VerifiedNumber[]
+  bannerUrl            String?


We need to modify the Avatar model to accept a new relationship for banners specifically asl well

why exactly? we also use Avatar model to store team logo/ org logo without any relation

/api/avatar/[uuid] -> gets image based on objectKey.

cc: @zomars

ciaranha · 2024-03-05T09:50:14Z

@keithwillcode @zomars do we have a timeline on when we can get this out? Priority is still only medium, just trying to align with some customer requests.

Udit-takkar · 2024-03-05T13:38:38Z

@keithwillcode @zomars do we have a timeline on when we can get this out? Priority is still only medium, just trying to align with some customer requests.

I have fixed all the conflicts let me ask someone to review

zomars

I'm getting this error when trying to upload the banner locally in Firefox

zomars

It works but still needs some work. We don't handle size limit errors properly. Also we display the banner as an avatar. Some designs are missing. Will approve due to the urgency but we should follow up.

zomars · 2024-03-06T23:18:58Z

Merge activity

Mar 6, 6:18 PM EST: @zomars merged this pull request with Graphite.

Udit-takkar · 2024-03-07T02:12:37Z

I'm getting this error when trying to upload the banner locally in Firefox

@zomars can you share what size file you were trying to upload?

zomars · 2024-03-07T03:49:48Z

I'm getting this error when trying to upload the banner locally in Firefox

@zomars can you share what size file you were trying to upload?

It was a 800kb file. But even then shouldn't the cropper handle resizing before upload?

PeerRich linked an issue Feb 12, 2024 that may be closed by this pull request

[CAL-3120] add a banner to org links #13643

Closed

github-actions bot added Medium priority Created by Linear-GitHub Sync organizations area: organizations, orgs ✨ feature New feature or request labels Feb 12, 2024

keithwillcode added the core area: core, team members only label Feb 12, 2024

vercel bot deployed to Preview – dev February 12, 2024 15:10 View deployment

vercel bot deployed to Preview – api February 12, 2024 15:21 View deployment

vercel bot had a problem deploying to Preview – ai February 12, 2024 15:24 Failure

keithwillcode requested a review from a team February 12, 2024 16:00

keithwillcode added this to the v3.9 milestone Feb 12, 2024

keithwillcode marked this pull request as draft February 13, 2024 05:28

vercel bot had a problem deploying to Preview – ai February 13, 2024 13:41 Failure

vercel bot deployed to Preview – api February 13, 2024 13:42 View deployment

vercel bot deployed to Preview – dev February 13, 2024 13:51 View deployment

vercel bot had a problem deploying to Preview – ai February 13, 2024 14:14 Failure

vercel bot deployed to Preview – api February 13, 2024 14:15 View deployment

vercel bot deployed to Preview – dev February 13, 2024 14:24 View deployment

vercel bot deployed to Preview – ai February 14, 2024 06:56 View deployment

vercel bot deployed to Preview – api February 14, 2024 06:59 View deployment

vercel bot deployed to Preview – dev February 14, 2024 07:08 View deployment

github-actions bot added the ❗️ migrations contains migration files label Feb 14, 2024

vercel bot deployed to Preview – ai February 14, 2024 11:22 View deployment

vercel bot had a problem deploying to Preview – api February 14, 2024 11:23 Failure

vercel bot deployed to Preview – dev February 14, 2024 11:35 View deployment

vercel bot deployed to Preview – dev February 15, 2024 17:29 View deployment

zomars reviewed Feb 15, 2024

View reviewed changes

Udit-takkar requested a review from zomars February 27, 2024 12:28

PeerRich added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Mar 5, 2024

PeerRich and others added 10 commits March 5, 2024 18:48

added banner for orgs

da67bb8

added inputs to org settings, needs schema

d8fa32b

moved banner into profile

6597425

nit

06dfa67

feat: wip

f5e71c5

feat: basic implementation

8d5d555

wip

8530c21

feat: upload banner functionality

3644d1b

chore: remove unused code

7bc47d0

fix: type err

da2440b

Udit-takkar force-pushed the 13643-cal-3120-add-a-banner-to-org-links branch from 0485484 to da2440b Compare March 5, 2024 13:31

github-actions bot added the Medium priority Created by Linear-GitHub Sync label Mar 5, 2024

vercel bot deployed to Preview – ai March 5, 2024 13:34 View deployment

vercel bot deployed to Preview – api March 5, 2024 13:37 View deployment

vercel bot deployed to Preview – dev March 5, 2024 13:48 View deployment

zomars approved these changes Mar 6, 2024

View reviewed changes

zomars merged commit dfd683f into main Mar 6, 2024
38 of 39 checks passed

zomars deleted the 13643-cal-3120-add-a-banner-to-org-links branch March 6, 2024 23:18

Udit-takkar mentioned this pull request Mar 7, 2024

[CAL-3327] Org banner follow up #13998

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added banner for orgs #13644

feat: added banner for orgs #13644

PeerRich commented Feb 12, 2024 •

edited by Udit-takkar

linear bot commented Feb 12, 2024

vercel bot commented Feb 12, 2024 •

edited

github-actions bot commented Feb 12, 2024 •

edited

github-actions bot commented Feb 12, 2024 •

edited

deploysentinel bot commented Feb 12, 2024 •

edited

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

keithwillcode commented Feb 13, 2024

zomars Feb 15, 2024

Udit-takkar Feb 16, 2024

Udit-takkar Feb 22, 2024

ciaranha commented Mar 5, 2024

Udit-takkar commented Mar 5, 2024 •

edited

zomars left a comment

zomars left a comment

zomars commented Mar 6, 2024

Udit-takkar commented Mar 7, 2024

zomars commented Mar 7, 2024

feat: added banner for orgs #13644

feat: added banner for orgs #13644

Conversation

PeerRich commented Feb 12, 2024 • edited by Udit-takkar

linear bot commented Feb 12, 2024

vercel bot commented Feb 12, 2024 • edited

github-actions bot commented Feb 12, 2024 • edited

github-actions bot commented Feb 12, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

One Page Changed Size

deploysentinel bot commented Feb 12, 2024 • edited

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

keithwillcode commented Feb 13, 2024

zomars Feb 15, 2024

Choose a reason for hiding this comment

Udit-takkar Feb 16, 2024

Choose a reason for hiding this comment

Udit-takkar Feb 22, 2024

Choose a reason for hiding this comment

ciaranha commented Mar 5, 2024

Udit-takkar commented Mar 5, 2024 • edited

zomars left a comment

Choose a reason for hiding this comment

zomars left a comment

Choose a reason for hiding this comment

zomars commented Mar 6, 2024

Merge activity

Udit-takkar commented Mar 7, 2024

zomars commented Mar 7, 2024

PeerRich commented Feb 12, 2024 •

edited by Udit-takkar

vercel bot commented Feb 12, 2024 •

edited

github-actions bot commented Feb 12, 2024 •

edited

github-actions bot commented Feb 12, 2024 •

edited

deploysentinel bot commented Feb 12, 2024 •

edited

Udit-takkar commented Mar 5, 2024 •

edited