Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disallowing use of Prisma includes using only "true" and not a field selector #13649

Closed
wants to merge 1 commit into from
Closed

feat: Disallowing use of Prisma includes using only "true" and not a field selector #13649

wants to merge 1 commit into from

Conversation

suyash5053
Copy link
Contributor

What does this PR do?

Created a linting rule for Prisma that disallow's use of Prisma, including only true not a field selector
Fixes #13577

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024

@suyash5053 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added foundation High priority Created by Linear-GitHub Sync labels Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@suyash5053 suyash5053 changed the title Disallowing use of Prisma includes using only "true" and not a field selector feat: Disallowing use of Prisma includes using only "true" and not a field selector Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added this to the v3.9 milestone Feb 13, 2024
@PeerRich PeerRich requested a review from a team February 13, 2024 10:55
@PeerRich PeerRich added High priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Feb 13, 2024
@PeerRich PeerRich modified the milestones: v3.9, v3.8 Feb 13, 2024
@suyash5053 suyash5053 mentioned this pull request Feb 13, 2024
Merged
1 task
@keithwillcode keithwillcode added Medium priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Feb 13, 2024
@keithwillcode
Copy link
Contributor

keithwillcode commented Feb 13, 2024 •
edited

Thank you for your contribution! This is also implemented in #13652, which is recursive. Going to favor that implementation

@suyash5053 suyash5053 deleted the 13577-cal-3087-linting-rule-for-prisma-using-true-not-field-selector branch February 13, 2024 14:53
@dosubot dosubot bot modified the milestones: v3.8, v4.1 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
foundation Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

[CAL-3087] Make linting rule disallowing use of Prisma includes using only "true" and not a field selector
3 participants
@suyash5053 @keithwillcode @PeerRich