fix: route always selects 'custom' after saving an event redirect #13665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
CarinaWolli
commented
Feb 13, 2024
| useEffect(() => { | ||
| if (!isLoading) { | ||
| const isCustom = !eventOptions.find((eventOption) => eventOption.value === route.action.value); | ||
| setCustomEventTypeSlug(isCustom ? route.action.value.split("/").pop() ?? "" : ""); |
There was a problem hiding this comment.
only set the CustomEventTypeSlug, when the event type doesn't exist in the eventOptions
added 2 commits
February 13, 2024 14:53
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/13/2024 08:19:10pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fb539fd Started: 02/13/2024 08:08:55pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox Question Select required and checkbox required
Retry 1 • Initial Attempt |
0% (0)0 / 275 runsfailed over last 7 days |
4% (11)11 / 275 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1 • Initial Attempt |
0.35% (1)1 / 284 runfailed over last 7 days |
5.63% (16)16 / 284 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
2.91% (8)8 / 275 runsfailed over last 7 days |
40% (110)110 / 275 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and multiselect Question Radio required and multiselect text required
Retry 1 • Initial Attempt |
0% (0)0 / 281 runsfailed over last 7 days |
5.69% (16)16 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address and Multi email not required
Retry 1 • Initial Attempt |
0% (0)0 / 287 runsfailed over last 7 days |
7.32% (21)21 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can add Cal video location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 291 runsfailed over last 7 days |
2.06% (6)6 / 291 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Can manage single schedule
Retry 1 • Initial Attempt |
0.35% (1)1 / 285 runfailed over last 7 days |
11.93% (34)34 / 285 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should test download button
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
8.68% (25)25 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone required and multiselect text not required
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 285 runsfailed over last 7 days |
5.26% (15)15 / 285 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.68% (2)2 / 292 runsfailed over last 7 days |
53.08% (155)155 / 292 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-114.81% (-155)-155 / 135 runsfailed over last 7 days |
115.56% (156)156 / 135 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-114.93% (-154)-154 / 134 runsfailed over last 7 days |
114.93% (154)154 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-114.93% (-154)-154 / 134 runsfailed over last 7 days |
114.93% (154)154 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-114.93% (-154)-154 / 134 runsfailed over last 7 days |
114.93% (154)154 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-114.18% (-153)-153 / 134 runsfailed over last 7 days |
114.18% (153)153 / 134 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-114.18% (-153)-153 / 134 runsfailed over last 7 days |
114.18% (153)153 / 134 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-115.04% (-153)-153 / 133 runsfailed over last 7 days |
115.04% (153)153 / 133 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0% (0)0 / 294 runsfailed over last 7 days |
4.76% (14)14 / 294 runsflaked over last 7 days |
PeerRich
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue that an event redirect route always switches to custom after saving, even when an event type was picked in the select. Everything was saved correctly to the db, this is just a displaying issue.