fix: Video app categories page need null safety #13674
Conversation
|
@A7Lavinraj is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite AutomationsA Graphite automation took an action on this PR • (02/14/24)1 label was added based on Keith Williams's automation, 'Add community label' A Graphite automation took an action on this PR • (02/14/24)1 reviewer was added based on Keith Williams's automation, 'Add foundation team as reviewer' |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
A7Lavinraj
force-pushed
the
fix/null-safety
branch
from
2513210
to
15ff74d
Compare
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
@A7Lavinraj Could you please remove yarn.lock file changes and the new migration file?
git checkout origin/main -- yarn.lock to undo the changes in yarn.lock file and push that yarn.lock file so it's the same as main branch
|
@Udit-takkar ok sir |
A7Lavinraj
force-pushed
the
fix/null-safety
branch
from
be13615
to
cfa41e2
Compare
|
@Udit-takkar sir, Is there any other improvement i must have to do? to get merge this pull request |
| @@ -47,7 +47,7 @@ export default function Apps({ apps }: PageProps) { | |||
| <div className="mb-16"> | |||
| <div className="grid-col-1 grid grid-cols-1 gap-3 md:grid-cols-3"> | |||
| {apps | |||
| .sort((a, b) => (b.installCount || 0) - (a.installCount || 0)) | |||
| ?.sort((a, b) => (b.installCount || 0) - (a.installCount || 0)) | |||
There was a problem hiding this comment.
i didn't got any error when i tried a category that doesn't exist even if i remove this change
There was a problem hiding this comment.
Sir, I got it in local development, I send a screenshot too
fix:#13673