Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop deprecated password column #13698

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

zomars
Copy link
Member

@zomars zomars commented Feb 14, 2024

What does this PR do?

Fixes #13664

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Copy link

linear bot commented Feb 14, 2024

@github-actions github-actions bot added the ❗️ migrations contains migration files label Feb 14, 2024
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added api area: API, enterprise API, access token, OAuth core area: core, team members only foundation labels Feb 14, 2024
@graphite-app graphite-app bot requested a review from a team February 14, 2024 21:58
Copy link

graphite-app bot commented Feb 14, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/14/24)

1 reviewer was added based on Keith Williams's automation, 'Add foundation team as reviewer'

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:00pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 14, 2024 10:00pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 14, 2024

Current Playwright Test Results Summary

✅ 447 Passing - ⚠️ 15 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/14/2024 10:17:12pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0cbacff

Started: 02/14/2024 10:08:26pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox group Question Multiple Email required and checkbox group required
Retry 1Initial Attempt
0.40% (1) 1 / 250 run
failed over last 7 days
4.40% (11) 11 / 250 runs
flaked over last 7 days

📄   apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking page with no questions Booking page with 1280x720 resolution
Retry 1Initial Attempt
0% (0) 0 / 254 runs
failed over last 7 days
4.33% (11) 11 / 254 runs
flaked over last 7 days

📄   apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text and checkbox required
Retry 1Initial Attempt
0.78% (2) 2 / 255 runs
failed over last 7 days
5.88% (15) 15 / 255 runs
flaked over last 7 days
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required
Retry 1Initial Attempt
0% (0) 0 / 254 runs
failed over last 7 days
5.91% (15) 15 / 254 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
0.79% (2) 2 / 254 runs
failed over last 7 days
45.28% (115) 115 / 254 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and multiselect Question Radio required and multiselect text required
Retry 1Initial Attempt
0% (0) 0 / 257 runs
failed over last 7 days
6.23% (16) 16 / 257 runs
flaked over last 7 days
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and select Question Radio required and select required
Retry 1Initial Attempt
0.39% (1) 1 / 256 run
failed over last 7 days
5.86% (15) 15 / 256 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1Initial Attempt
0.39% (1) 1 / 257 run
failed over last 7 days
7.39% (19) 19 / 257 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and multiselect Question Checkbox Group and multiselect text not required
Retry 1Initial Attempt
0% (0) 0 / 256 runs
failed over last 7 days
4.69% (12) 12 / 256 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 2Retry 1Initial Attempt
0.76% (2) 2 / 262 runs
failed over last 7 days
14.89% (39) 39 / 262 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Phone Question Address required and Phone required
Retry 1Initial Attempt
0% (0) 0 / 259 runs
failed over last 7 days
5.79% (15) 15 / 259 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address required and Radio group required
Retry 1Initial Attempt
0.39% (1) 1 / 259 run
failed over last 7 days
4.25% (11) 11 / 259 runs
flaked over last 7 days
Booking With Address Question and Each Other Question Booking With Address Question and Short text question Address required and Short text required
Retry 1Initial Attempt
0.39% (1) 1 / 259 run
failed over last 7 days
6.18% (16) 16 / 259 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone and multiselect text required
Retry 1Initial Attempt
0% (0) 0 / 261 runs
failed over last 7 days
6.51% (17) 17 / 261 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
3.80% (10) 10 / 263 runs
failed over last 7 days
16.73% (44) 44 / 263 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added this to the v3.8 milestone Feb 15, 2024
@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Feb 15, 2024
@keithwillcode keithwillcode marked this pull request as draft February 15, 2024 12:01
@keithwillcode keithwillcode modified the milestones: v3.8, v3.9 Feb 15, 2024
@zomars zomars marked this pull request as ready for review February 19, 2024 20:36
@zomars zomars enabled auto-merge (squash) February 19, 2024 20:37
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to merge

@zomars zomars merged commit 008e0e4 into main Feb 20, 2024
41 of 42 checks passed
@zomars zomars deleted the zomars/cal-3124-drop-deprecated-password-column branch February 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only foundation High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3124] Drop deprecated password column
4 participants