fix: password reset when provider is changed #13706
Conversation
Udit-takkar
requested review from
ThyMinimalDev
and removed request for
a team
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/15/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 63 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/15/2024 01:18:08pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ad6c1d6 Started: 02/15/2024 01:15:29pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0.40% (1)1 / 249 runfailed over last 7 days |
49.40% (123)123 / 249 runsflaked over last 7 days |
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
11.65% (29)29 / 249 runsfailed over last 7 days |
54.22% (135)135 / 249 runsflaked over last 7 days |
| }, | ||
| }, | ||
| emailVerified: new Date(), | ||
| }, | ||
| }); | ||
| } catch (e) { | ||
| console.error("Error updating password", e); |
There was a problem hiding this comment.
the error is not necessarily related to updating the password, could also fail if the email is not found
| }, | ||
| }, | ||
| emailVerified: new Date(), | ||
| }, | ||
| }); | ||
| } catch (e) { | ||
| console.error("Error updating password", e); |
There was a problem hiding this comment.
This has the potential to thoroughly spam our logs if someone bruteforces the password reset
There was a problem hiding this comment.
should i remove the log then?
There was a problem hiding this comment.
or add checkRateLimitAndThrowError
There was a problem hiding this comment.
i think we can just remove the log
What does this PR do?
Fixes
How to reproduce the bug?
Login in with google
Change your email which would send password reset email and change your provider from google to CAL