fix: team invite signup not working #13717

hariombalhara · 2024-02-16T07:05:49Z

What does this PR do?

Fixes #13719

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

NOTE: It isn't possible to test this flow using e2e

github-actions · 2024-02-16T07:06:01Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

hariombalhara · 2024-02-16T07:07:15Z

packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts

@@ -235,10 +235,11 @@ export async function createNewUsersConnectToOrgIfExists({
        const usernameOrEmail = usernamesOrEmails[index];
        const { orgId, autoAccept } = connectionInfoMap[usernameOrEmail];
        const [emailUser, emailDomain] = usernameOrEmail.split("@");
-        const username =
-          emailDomain === autoAcceptEmailDomain
+        const username = input.isOrg


For a non sub-team invite, we shouldn't set username during the invite as user is allowed to change the username during the signup.

vercel · 2024-02-16T07:08:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Feb 16, 2024 0:24am
cal	⬜️ Ignored (Inspect)	Visit Preview	Feb 16, 2024 0:24am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Feb 16, 2024 0:24am
qa	⬜️ Ignored (Inspect)	Visit Preview	Feb 16, 2024 0:24am

github-actions · 2024-02-16T07:16:03Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

hariombalhara · 2024-02-16T07:19:19Z

packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts

-          emailDomain === autoAcceptEmailDomain
-            ? slugify(emailUser)
-            : slugify(`${emailUser}-${emailDomain.split(".")[0]}`);
+          input.isOrg || parentId


Ensures that for a regular team the username isn't set because user is allowed to change the username during signup in that context.

deploysentinel · 2024-02-16T07:25:37Z

Current Playwright Test Results Summary

✅ 63 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/16/2024 12:49:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7284929

Started: 02/16/2024 12:46:48pm UTC

⚠️ Flakes

📄 apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Cannot update a users email when existing user has same email (verification enabled) Retry 1 • Initial Attempt	0.39% (1) 1 / 256 run failed over last 7 days	49.61% (127) 127 / 256 runs flaked over last 7 days
Update Profile Can update a users email (verification enabled) Retry 2 • Retry 1 • Initial Attempt	12.11% (31) 31 / 256 runs failed over last 7 days	51.56% (132) 132 / 256 runs flaked over last 7 days

View Detailed Build Results

graphite-app · 2024-02-16T07:40:13Z

Graphite Automations

A Graphite automation took an action on this PR • (02/16/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

hariombalhara · 2024-02-16T07:41:28Z

packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts

          emailDomain === autoAcceptEmailDomain
            ? slugify(emailUser)
            : slugify(`${emailUser}-${emailDomain.split(".")[0]}`);

+        // As a regular team member is allowed to change username during signup, we don't set any username for him
+        const regularTeamMemberUsername = null;


I think we accidentally started setting it for regular teams by this PR
https://github.com/calcom/cal.com/pull/11238/files
cc @joeauyeung for confirmation

Udit-takkar

LGTM. Regular Team invites are working fine.

Checking orgs now

* Fix team invite signup not working * Add unit test --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

keithwillcode added consumer core area: core, team members only labels Feb 16, 2024

hariombalhara commented Feb 16, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – api February 16, 2024 07:08 Failure

vercel bot deployed to Preview – ai February 16, 2024 07:08 View deployment

hariombalhara force-pushed the fix-team-invite-calcom-handler branch from 08c3f17 to 3093e71 Compare February 16, 2024 07:14

hariombalhara added the High priority Created by Linear-GitHub Sync label Feb 16, 2024

vercel bot had a problem deploying to Preview – api February 16, 2024 07:17 Failure

vercel bot deployed to Preview – ai February 16, 2024 07:17 View deployment

hariombalhara commented Feb 16, 2024

View reviewed changes

hariombalhara changed the title ~~Fix team invite signup not working~~ fix: team invite signup not working Feb 16, 2024

hariombalhara force-pushed the fix-team-invite-calcom-handler branch from 3093e71 to 2400067 Compare February 16, 2024 07:26

github-actions bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Feb 16, 2024

vercel bot deployed to Preview – ai February 16, 2024 07:29 View deployment

vercel bot deployed to Preview – api February 16, 2024 07:32 View deployment

Fix team invite signup not working

b9ed91c

hariombalhara force-pushed the fix-team-invite-calcom-handler branch from 2400067 to b9ed91c Compare February 16, 2024 07:36

hariombalhara marked this pull request as ready for review February 16, 2024 07:36

graphite-app bot requested a review from a team February 16, 2024 07:36

hariombalhara requested review from ThyMinimalDev and a team and removed request for a team February 16, 2024 07:36

vercel bot deployed to Preview – ai February 16, 2024 07:38 View deployment

hariombalhara commented Feb 16, 2024

View reviewed changes

vercel bot deployed to Preview – api February 16, 2024 07:42 View deployment

hariombalhara requested review from zomars, CarinaWolli and joeauyeung February 16, 2024 07:42

vercel bot deployed to Preview – dev February 16, 2024 08:05 View deployment

vercel bot deployed to Preview – api February 16, 2024 08:38 View deployment

vercel bot deployed to Preview – dev February 16, 2024 08:48 View deployment

Add unit test

98ccaba

hariombalhara force-pushed the fix-team-invite-calcom-handler branch from ed388d9 to 98ccaba Compare February 16, 2024 10:42

vercel bot deployed to Preview – api February 16, 2024 10:47 View deployment

vercel bot deployed to Preview – dev February 16, 2024 10:57 View deployment

PeerRich added the Urgent Created by Linear-GitHub Sync label Feb 16, 2024

PeerRich requested a review from a team February 16, 2024 11:55

Udit-takkar reviewed Feb 16, 2024

View reviewed changes

Udit-takkar approved these changes Feb 16, 2024

View reviewed changes

Merge branch 'main' into fix-team-invite-calcom-handler

7284929

Udit-takkar enabled auto-merge (squash) February 16, 2024 12:28

vercel bot deployed to Preview – api February 16, 2024 12:29 View deployment

vercel bot deployed to Preview – dev February 16, 2024 12:40 View deployment

Udit-takkar merged commit ff6db3c into main Feb 16, 2024
38 checks passed

Udit-takkar deleted the fix-team-invite-calcom-handler branch February 16, 2024 12:50

keithwillcode pushed a commit that referenced this pull request Feb 16, 2024

fix: team invite signup not working (#13717)

2f1316a

* Fix team invite signup not working * Add unit test --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: team invite signup not working #13717

fix: team invite signup not working #13717

hariombalhara commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

hariombalhara Feb 16, 2024

vercel bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

hariombalhara Feb 16, 2024

deploysentinel bot commented Feb 16, 2024 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

graphite-app bot commented Feb 16, 2024

hariombalhara Feb 16, 2024

Udit-takkar left a comment

fix: team invite signup not working #13717

fix: team invite signup not working #13717

Conversation

hariombalhara commented Feb 16, 2024 • edited Loading

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

github-actions bot commented Feb 16, 2024 • edited Loading

hariombalhara Feb 16, 2024

Choose a reason for hiding this comment

vercel bot commented Feb 16, 2024 • edited Loading

github-actions bot commented Feb 16, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

hariombalhara Feb 16, 2024

Choose a reason for hiding this comment

deploysentinel bot commented Feb 16, 2024 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

graphite-app bot commented Feb 16, 2024

Graphite Automations

hariombalhara Feb 16, 2024

Choose a reason for hiding this comment

Udit-takkar left a comment

Choose a reason for hiding this comment

hariombalhara commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

vercel bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

deploysentinel bot commented Feb 16, 2024 •

edited

Loading