fix: Managed children event listing for organization members #13722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts that dont belong to the user
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/16/2024 12:21:54pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cbaed91 Started: 02/16/2024 12:16:24pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Number Question Select and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 234 runsfailed over last 7 days |
5.13% (12)12 / 234 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Multiple email Question Long Text and Multiple email required
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
4.76% (11)11 / 231 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 230 runsfailed over last 7 days |
7.39% (17)17 / 230 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.42% (1)1 / 236 runfailed over last 7 days |
44.92% (106)106 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/booking/responsiveBooking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With no questions Booking with 1280x720 resolution and no questions
Retry 1 • Initial Attempt |
0% (0)0 / 235 runsfailed over last 7 days |
0.43% (1)1 / 235 runflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
11.81% (30)30 / 254 runsfailed over last 7 days |
51.57% (131)131 / 254 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
4.44% (11)11 / 248 runsfailed over last 7 days |
16.53% (41)41 / 248 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present
Retry 1 • Initial Attempt |
0% (0)0 / 244 runsfailed over last 7 days |
4.10% (10)10 / 244 runsflaked over last 7 days |
📄 apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1 • Initial Attempt |
0% (0)0 / 246 runsfailed over last 7 days |
15.45% (38)38 / 246 runsflaked over last 7 days |
alishaz-polymath
changed the title
alishaz-polymath
changed the title
github-actions
bot
added
teams
hariombalhara
force-pushed
the
fix-event-types-in-org
branch
2 times, most recently
from
aa51559
to
53a961d
Compare
Graphite AutomationsA Graphite automation took an action on this PR • (02/16/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
hariombalhara
force-pushed
the
fix-event-types-in-org
branch
from
53a961d
to
11c7546
Compare
hariombalhara
changed the title
hariombalhara
force-pushed
the
fix-event-types-in-org
branch
from
11c7546
to
cbaed91
Compare
hariombalhara
commented
Feb 16, 2024
| @@ -156,6 +156,13 @@ export class EventTypeRepository { | |||
| { | |||
| profileId, | |||
| }, | |||
| // Fetch children event-types by userId because profileId is wrong | |||
There was a problem hiding this comment.
profileId is wrong for children event-types. Will open a separate PR to fix that and add a migration to fix existing data.
hariombalhara
commented
Feb 16, 2024
| const isAChildEvent = eventType.parentId; | ||
| // A child event only has one user | ||
| const childEventAssignee = eventType.users[0]; | ||
| if (isAChildEvent && childEventAssignee.id != ctx.user.id) { |
There was a problem hiding this comment.
If there is a childEvent that doesn't belong to the user remove that.
alishaz-polymath
approved these changes
Feb 16, 2024
keithwillcode
approved these changes
Feb 16, 2024
keithwillcode
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Fetch event-types by userId for childEvents and filter out those events that dont belong to the user * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes managed event-types listing in dashboard for organization members.
The root cause is that the profileId is wrongly set for children event-types.
Fixes #13723
Type of change
How should this be tested?
Mandatory Tasks
Checklist