chore: Refactor feature flags #13734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/16/24)1 reviewer was added based on Keith Williams's automation, 'Add platform team as reviewer' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/20/2024 02:28:01pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d29f2dd Started: 02/20/2024 02:17:10pm UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Multiple email Question Long Text and Multiple email required
Retry 1 • Initial Attempt |
0% (0)0 / 228 runsfailed over last 7 days |
6.14% (14)14 / 228 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and select Question Long Text and select required
Retry 1 • Initial Attempt |
0% (0)0 / 224 runsfailed over last 7 days |
7.59% (17)17 / 224 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Short text question Long Text required and Short text not required
Retry 1 • Initial Attempt |
0% (0)0 / 224 runsfailed over last 7 days |
4.91% (11)11 / 224 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
8.30% (20)20 / 241 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select required and select required
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
5.39% (13)13 / 241 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Phone Question Select and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
4.98% (12)12 / 241 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.42% (1)1 / 238 runfailed over last 7 days |
43.28% (103)103 / 238 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 2 • Retry 1 • Initial Attempt |
1.23% (3)3 / 243 runsfailed over last 7 days |
2.88% (7)7 / 243 runsflaked over last 7 days |
📄 apps/web/playwright/booking/allQuestions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With All Questions Selecting and filling all questions as optional
Retry 1 • Initial Attempt |
0% (0)0 / 234 runsfailed over last 7 days |
4.27% (10)10 / 234 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and select Question Phone required and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 246 runsfailed over last 7 days |
4.07% (10)10 / 246 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.41% (1)1 / 243 runfailed over last 7 days |
4.94% (12)12 / 243 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
3.64% (9)9 / 247 runsfailed over last 7 days |
18.62% (46)46 / 247 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
1.57% (4)4 / 255 runsfailed over last 7 days |
49.02% (125)125 / 255 runsflaked over last 7 days |
apps/api/v2/src/modules/slots/controllers/slots.controller.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Since feature flags are reused everywhere I'd rather cache them all than every single one. There are not that many records and IMO it's better to have this data from a single reusable query than multiple ones |
Fair point |
zomars
previously approved these changes
Feb 19, 2024
zomars
previously requested changes
Feb 19, 2024
keithwillcode
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors
getFeatureFlagMapinto a more concise and single-usegetFeatureFlag, caching the whole feature flag map seems unnecessary as most of these will not be used all at once.