fix: rescheduling daily #13736
Merged
fix: rescheduling daily #13736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bookings
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/13/2024 01:21:16pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f22d6e3 Started: 04/13/2024 01:17:27pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option
Retry 2 • Retry 1 • Initial Attempt |
0.37% (1)1 / 270 runfailed over last 7 days |
3.33% (9)9 / 270 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
4.56% (12)12 / 263 runsfailed over last 7 days |
31.94% (84)84 / 263 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 1 • Initial Attempt |
0.36% (1)1 / 280 runfailed over last 7 days |
25.36% (71)71 / 280 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 270 runsfailed over last 7 days |
11.85% (32)32 / 270 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 2 • Retry 1 • Initial Attempt |
0.37% (1)1 / 269 runfailed over last 7 days |
34.57% (93)93 / 269 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
6.69% (18)18 / 269 runsfailed over last 7 days |
24.91% (67)67 / 269 runsflaked over last 7 days |
|
Update Profile Can verify the newly added secondary email
Retry 1 • Initial Attempt |
0% (0)0 / 267 runsfailed over last 7 days |
6.37% (17)17 / 267 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1 • Initial Attempt |
9.22% (26)26 / 282 runsfailed over last 7 days |
35.11% (99)99 / 282 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done existing user migrated to an organization
Retry 1 • Initial Attempt |
0% (0)0 / 269 runsfailed over last 7 days |
4.46% (12)12 / 269 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 270 runsfailed over last 7 days |
41.85% (113)113 / 270 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.74% (2)2 / 270 runsfailed over last 7 days |
54.07% (146)146 / 270 runsflaked over last 7 days |
sean-brydon
previously approved these changes
Feb 19, 2024
CarinaWolli
reviewed
Feb 19, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
CarinaWolli
previously approved these changes
Feb 19, 2024
Udit-takkar
commented
Apr 13, 2024
Comment on lines
-83
to
-88
| await expectEmailsToHaveSubject({ | ||
| emails, | ||
| organizer: user, | ||
| booker: bookerObj, | ||
| eventTitle, | ||
| }); |
There was a problem hiding this comment.
this works fine locally but fails on CI.
There was a problem hiding this comment.
added a new unit test instead "cannot book same slot multiple times" in fresh-booking to make sure which would check the email has been delivered to both booker and organizer
I tried that in production and the daily link did show the updated date and time. How do I reproduce this bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13563
Fixes #14502
Fixes CAL-3389
Rescheduling works fine for daily video but doesn't work when your location is empty string. It could be possible when there is no location selected on event type settings.
updateMeeting(in dailyvideo/lib/VideoApiAdapter) was never called because location is empty string.
How to reproduce the bug?
Then check the location url is daily video url and check sidebar if it is updated to new date and time
Type of change