fix: No available users found #13738

keithwillcode · 2024-02-16T23:20:21Z

What does this PR do?

Fixes #13311, #13747, #13709

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

ensure test suite passes
ensure that you can book 1 individual slot on a future date that is only available because a date override has been set

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

github-actions · 2024-02-16T23:20:33Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-02-16T23:20:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Feb 20, 2024 2:07pm
cal	⬜️ Ignored (Inspect)	Visit Preview	Feb 20, 2024 2:07pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Feb 20, 2024 2:07pm
qa	⬜️ Ignored (Inspect)	Visit Preview	Feb 20, 2024 2:07pm

keithwillcode · 2024-02-16T23:26:20Z

packages/features/bookings/lib/handleNewBooking.ts

@@ -339,15 +339,25 @@ export async function ensureAvailableUsers(
    });
  }

+  const getStartTime = (startTimeInput: string, timeZone?: string) => {


This code was taken from packages/trpc/server/routers/viewers/slots/util.ts so that we mirror how the getUserAvailability function is called.

I noticed that the .utc() function was being called for the endTime but not the startTime. Have added that here and will look to see if util.ts needs it to be added as well.

Is the startTimeInput in Zulu format or something like 2024-10-01T05:00 ?

If it isn't in Zulu format or ISO format. It reads the time in local tz. So if you run dayjs("2024-10-01T05:00") in India.

It will be 2024-10-01T05:00:00+05:30.

Then we convert it into the specified timezone.

And then to UTC.

Which I guess isn't what we want.

I think here we are thinking of reading 2024-10-01T05:00 in the specified timezone.
For that you need to do something like dayjs.tz(2024-10-01T05:00, timeZone)

And I guess github actions are run in UTC tz, so It won't show any errors. And the productions server will be fine to as long as it is in UTC too.

Just my 2 cents, as I have been working with dayjs alot in recent days and have gone through many gotchas.

It's in ISO format with the timezone information included. So, for example, if on the booking page you select New York for the time zone, it will pass 2024-02-17T12:00:00-05:00.

The main problem is that we were calling stringToDayjs with this string and it was never being converted to UTC before doing all the appropriate checks and so the time slots weren't lining up properly, resulting in "No available users found" errors.

github-actions · 2024-02-16T23:31:25Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-02-16T23:32:11Z

Current Playwright Test Results Summary

✅ 81 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/20/2024 03:04:43pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 6997ab4

Started: 02/20/2024 03:01:17pm UTC

⚠️ Flakes

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 1 • Initial Attempt	0.42% (1) 1 / 239 run failed over last 7 days	43.51% (104) 104 / 239 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address Retry 1 • Initial Attempt	0% (0) 0 / 245 runs failed over last 7 days	18.78% (46) 46 / 245 runs flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests can add single organizer address location without display location public option Retry 1 • Initial Attempt	0.41% (1) 1 / 244 run failed over last 7 days	2.87% (7) 7 / 244 runs flaked over last 7 days

📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Users can impersonate App Admin can impersonate users with impersonation enabled Retry 1 • Initial Attempt	0% (0) 0 / 244 runs failed over last 7 days	10.66% (26) 26 / 244 runs flaked over last 7 days

View Detailed Build Results

keithwillcode · 2024-02-20T03:33:13Z

packages/features/bookings/lib/handleNewBooking/test/date-overrides.test.ts

+
+  describe("Booking for slot only available by date override:", () => {
+    test(
+      `should be able to create a booking for the exact slot overridden`,


First wrote this test against main and saw it fail. Then made it pass in this branch.

packages/features/bookings/lib/handleNewBooking.ts

Co-authored-by: Omar López <zomars@me.com>

zomars

Very nice!

CarinaWolli

Fix looks good, did a lot of testing and everything worked for me. When testing I found one more case were this error is thrown, I left a comment

packages/features/bookings/lib/handleNewBooking.ts

…o fix/cannot-book-ny-tz

fix: No available users found

f3e9316

keithwillcode added the Urgent Created by Linear-GitHub Sync label Feb 16, 2024

keithwillcode added this to the v3.9 milestone Feb 16, 2024

keithwillcode requested a review from a team February 16, 2024 23:20

keithwillcode self-assigned this Feb 16, 2024

keithwillcode added core area: core, team members only foundation labels Feb 16, 2024

Update getUserAvailability.ts

49d32cf

keithwillcode added 2 commits February 16, 2024 20:21

Update getUserAvailability.ts

23fc4d8

Update handleNewBooking.ts

5f23bf4

vercel bot deployed to Preview – ai February 16, 2024 23:25 View deployment

keithwillcode commented Feb 16, 2024

View reviewed changes

vercel bot deployed to Preview – api February 16, 2024 23:31 View deployment

vercel bot deployed to Preview – dev February 16, 2024 23:50 View deployment

keithwillcode mentioned this pull request Feb 17, 2024

fix: Issue with "Limit total booking duration" and offering seats #13526

Open

2 tasks

Reusing the parsed dates throughout the full stack

d62cc56

github-actions bot added High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 17, 2024

vercel bot had a problem deploying to Preview – api February 17, 2024 12:54 Failure

Fixed typo

0b26dc3

vercel bot had a problem deploying to Preview – api February 17, 2024 13:01 Failure

vercel bot deployed to Preview – dev February 17, 2024 13:20 View deployment

Added unit tests for stringToDayjs

d14f04d

vercel bot deployed to Preview – ai February 17, 2024 13:30 View deployment

vercel bot had a problem deploying to Preview – api February 17, 2024 13:30 Failure

vercel bot deployed to Preview – dev February 17, 2024 13:42 View deployment

keithwillcode marked this pull request as ready for review February 20, 2024 03:25

keithwillcode commented Feb 20, 2024

View reviewed changes

vercel bot deployed to Preview – api February 20, 2024 03:33 View deployment

vercel bot deployed to Preview – dev February 20, 2024 03:46 View deployment

zomars reviewed Feb 20, 2024

View reviewed changes

packages/features/bookings/lib/handleNewBooking.ts Outdated Show resolved Hide resolved

keithwillcode and others added 2 commits February 20, 2024 01:08

Update packages/features/bookings/lib/handleNewBooking.ts

c191b3c

Co-authored-by: Omar López <zomars@me.com>

Update handleNewBooking.ts

c19d695

keithwillcode added 🐛 bug Something isn't working and removed High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 20, 2024

vercel bot deployed to Preview – api February 20, 2024 04:16 View deployment

vercel bot deployed to Preview – dev February 20, 2024 04:40 View deployment

zomars previously approved these changes Feb 20, 2024

View reviewed changes

CarinaWolli reviewed Feb 20, 2024

View reviewed changes

packages/features/bookings/lib/handleNewBooking.ts Show resolved Hide resolved

keithwillcode marked this pull request as draft February 20, 2024 13:18

keithwillcode added 2 commits February 20, 2024 11:03

Fixed issue where date overrides ending at midnight don't allow bookings

55ca5dd

Merge branch 'main' into fix/cannot-book-ny-tz

a0ecdd0

github-actions bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Feb 20, 2024

Merge branch 'fix/cannot-book-ny-tz' of github.com:calcom/cal.com int…

5b1a8ad

…o fix/cannot-book-ny-tz

keithwillcode dismissed zomars’s stale review via 5b1a8ad February 20, 2024 14:06

Removed comment

6997ab4

vercel bot deployed to Preview – api February 20, 2024 14:15 View deployment

vercel bot deployed to Preview – dev February 20, 2024 14:35 View deployment

keithwillcode requested review from CarinaWolli and zomars February 20, 2024 15:08

keithwillcode marked this pull request as ready for review February 20, 2024 15:08

zomars approved these changes Feb 20, 2024

View reviewed changes

keithwillcode merged commit 7157448 into main Feb 20, 2024
39 checks passed

keithwillcode deleted the fix/cannot-book-ny-tz branch February 20, 2024 15:15

keithwillcode mentioned this pull request Feb 20, 2024

[CAL-3148] Booking an event in US timezone leads to "Could not book this meeting error" #13709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: No available users found #13738

fix: No available users found #13738

keithwillcode commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

vercel bot commented Feb 16, 2024 •

edited

Loading

keithwillcode Feb 16, 2024 •

edited

Loading

MehulZR Feb 17, 2024 •

edited

Loading

MehulZR Feb 17, 2024

MehulZR Feb 17, 2024 •

edited

Loading

keithwillcode Feb 17, 2024

keithwillcode Feb 17, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

deploysentinel bot commented Feb 16, 2024 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

keithwillcode Feb 20, 2024

zomars left a comment

CarinaWolli left a comment

fix: No available users found #13738

fix: No available users found #13738

Conversation

keithwillcode commented Feb 16, 2024 • edited Loading

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

github-actions bot commented Feb 16, 2024 • edited Loading

vercel bot commented Feb 16, 2024 • edited Loading

keithwillcode Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

MehulZR Feb 17, 2024 • edited Loading

Choose a reason for hiding this comment

MehulZR Feb 17, 2024

Choose a reason for hiding this comment

MehulZR Feb 17, 2024 • edited Loading

Choose a reason for hiding this comment

keithwillcode Feb 17, 2024

Choose a reason for hiding this comment

keithwillcode Feb 17, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 16, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Feb 16, 2024 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

keithwillcode Feb 20, 2024

Choose a reason for hiding this comment

zomars left a comment

Choose a reason for hiding this comment

CarinaWolli left a comment

Choose a reason for hiding this comment

keithwillcode commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

vercel bot commented Feb 16, 2024 •

edited

Loading

keithwillcode Feb 16, 2024 •

edited

Loading

MehulZR Feb 17, 2024 •

edited

Loading

MehulZR Feb 17, 2024 •

edited

Loading

keithwillcode Feb 17, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

deploysentinel bot commented Feb 16, 2024 •

edited

Loading