fix: correct German translation #13742
Conversation
|
@mokkin is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite AutomationsA Graphite automation took an action on this PR • (02/18/24)1 label was added based on Keith Williams's automation, 'Add community label' |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| @@ -607,7 +607,7 @@ | |||
| "danger_zone": "Achtung", | |||
| "account_deletion_cannot_be_undone": "Vorsicht. Löschen eines Kontos kann nicht rückgängig gemacht werden.", | |||
| "back": "Zurück", | |||
| "cancel": "Absagen", | |||
| "cancel": "Abbrechen", | |||
There was a problem hiding this comment.
@mokkin don't both of those words have the same meaning?
There was a problem hiding this comment.
Actually not @Ryukemeister
Indeed they have a similar meaning and English "cancel" is used for both contexts.
In German "Absagen" is used specifically for upcoming events and appointments before they begin while "Abbrechen" means to cancel some process or dialogue that is happening right now.
There was a problem hiding this comment.
in that case @PeerRich you might be the best person here
There was a problem hiding this comment.
here's the problem, we need to introduce two types of "cancel"
because we also use "Cancel" in a different context for "Cancel appointment" which where "Meeting absagen" is correct.
which means we need to introduce a new variable:
"cancel": "Abbrechen",
"cancel_action": "Abbrechen",
and then use the cancel_action in all places where cancel needs to be "Abbrechen"
There was a problem hiding this comment.
but i think we can merge this, but i will need to watch out where we use "Abbrechen" correclty
There was a problem hiding this comment.
here's the problem, we need to introduce two types of "cancel"
because we also use "Cancel" in a different context for "Cancel appointment" which where "Meeting absagen" is correct.
which means we need to introduce a new variable:
"cancel": "Abbrechen", "cancel_action": "Abbrechen",
and then use the cancel_action in all places where cancel needs to be "Abbrechen"
That's right! The "cancel" I was referring to is the "cancel_action" such as in every dialogue like here in LibreOffice for example at no. 2:
keithwillcode
added
Low priority
What does this PR do?
correct German translation
Type of change
How should this be tested?
Mandatory Tasks
Checklist