feat: Settings for dashboard theme that is separate from system #13779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we had appTheme now, I think it's better to update the wording here to avoid confusion
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/20/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/21/2024 01:00:52pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b824845 Started: 02/21/2024 12:50:41pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and checkbox group Question Select required and checkbox group required
Retry 1 • Initial Attempt |
0% (0)0 / 235 runsfailed over last 7 days |
6.38% (15)15 / 235 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select and Long text not required
Retry 1 • Initial Attempt |
0.43% (1)1 / 235 runfailed over last 7 days |
8.94% (21)21 / 235 runsflaked over last 7 days |
📄 apps/web/playwright/booking/collectiveEventType/collectiveEventType.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Collective event type Book a Collective event type
Retry 1 • Initial Attempt |
0.45% (1)1 / 220 runfailed over last 7 days |
1.36% (3)3 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.43% (1)1 / 230 runfailed over last 7 days |
42.61% (98)98 / 230 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 236 runsfailed over last 7 days |
3.81% (9)9 / 236 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-4.24% (-10)-10 / 236 runsfailed over last 7 days |
58.90% (139)139 / 236 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-113.08% (-121)-121 / 107 runsfailed over last 7 days |
116.82% (125)125 / 107 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-121.36% (-125)-125 / 103 runsfailed over last 7 days |
121.36% (125)125 / 103 runsflaked over last 7 days |
📄 apps/web/playwright/organization/across-org/across-org.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1 • Initial Attempt |
0.42% (1)1 / 238 runfailed over last 7 days |
16.81% (40)40 / 238 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
15.79% (39)39 / 247 runsfailed over last 7 days |
48.99% (121)121 / 247 runsflaked over last 7 days |
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
1.63% (4)4 / 246 runsfailed over last 7 days |
50% (123)123 / 246 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.24% (3)3 / 241 runsfailed over last 7 days |
40.66% (98)98 / 241 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventy-eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
github-actions
bot
added
community
Udit-takkar
approved these changes
Feb 20, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took over from : #12633
Fixes: #11997 CAL-2761
Most of the credit goes to @swh00tw: I couldnt push changes to your PR #12633 so i just thought it'd be easier to push my own.
Loom: https://github.com/calcom/cal.com/assets/55134778/a3537270-654c-4370-a7f9-a9f9581e0381