fix: prefillFormParams guest type #13798
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
High priority
keithwillcode
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/21/24)1 reviewer was added based on Keith Williams's automation, 'Add platform team as reviewer' A Graphite automation took an action on this PR • (02/21/24)1 reviewer was added based on Keith Williams's automation, 'Add foundation team as reviewer' |
keithwillcode
approved these changes
Feb 21, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/21/2024 12:35:24pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 42951ff Started: 02/21/2024 12:28:44pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
prefill -- legacy logged in
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
3.64% (8)8 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Address Question Multiple Email and Address not required
Retry 1 • Initial Attempt |
0.46% (1)1 / 217 runfailed over last 7 days |
2.76% (6)6 / 217 runsflaked over last 7 days |
📄 apps/web/playwright/booking/selectQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select and Long text not required
Retry 1 • Initial Attempt |
0.43% (1)1 / 233 runfailed over last 7 days |
8.58% (20)20 / 233 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Multi email Question Select required and Multi email required
Retry 1 • Initial Attempt |
0% (0)0 / 233 runsfailed over last 7 days |
5.15% (12)12 / 233 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Select Question and Radio group Question Select and Radio group not required
Retry 1 • Initial Attempt |
0.43% (1)1 / 231 runfailed over last 7 days |
5.19% (12)12 / 231 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.44% (1)1 / 228 runfailed over last 7 days |
42.54% (97)97 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Number Question Long Text and Number required
Retry 1 • Initial Attempt |
0.46% (1)1 / 216 runfailed over last 7 days |
6.02% (13)13 / 216 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group required and Short Text required
Retry 1 • Initial Attempt |
0.46% (1)1 / 218 runfailed over last 7 days |
4.59% (10)10 / 218 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Multi email Question Address required and Multi email required
Retry 1 • Initial Attempt |
0.44% (1)1 / 227 runfailed over last 7 days |
7.49% (17)17 / 227 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Radio group Question Address and Radio group not required
Retry 1 • Initial Attempt |
0% (0)0 / 226 runsfailed over last 7 days |
6.64% (15)15 / 226 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization Team Invitation
Retry 1 • Initial Attempt |
0% (0)0 / 225 runsfailed over last 7 days |
12.44% (28)28 / 225 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-4.27% (-10)-10 / 234 runsfailed over last 7 days |
58.97% (138)138 / 234 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-113.21% (-120)-120 / 106 runsfailed over last 7 days |
116.98% (124)124 / 106 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-121.57% (-124)-124 / 102 runsfailed over last 7 days |
121.57% (124)124 / 102 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 236 runsfailed over last 7 days |
12.71% (30)30 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
15.92% (39)39 / 245 runsfailed over last 7 days |
48.98% (120)120 / 245 runsflaked over last 7 days |
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
1.64% (4)4 / 244 runsfailed over last 7 days |
49.59% (121)121 / 244 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 239 runsfailed over last 7 days |
36.82% (88)88 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/settings/upload-avatar.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
UploadAvatar can upload an image
Retry 1 • Initial Attempt |
1.67% (4)4 / 239 runsfailed over last 7 days |
3.35% (8)8 / 239 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13796
Mandatory Tasks
Checklist