fix: Type check failure in occupiedSeats #13805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
keithwillcode
approved these changes
Feb 21, 2024
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 112 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/22/2024 10:26:28am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 1d6055b Started: 02/22/2024 10:20:48am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Multiple email Question Long Text and Multiple email required
Retry 1 • Initial Attempt |
0% (0)0 / 215 runsfailed over last 7 days |
6.98% (15)15 / 215 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group and Phone not required
Retry 1 • Initial Attempt |
0% (0)0 / 222 runsfailed over last 7 days |
8.56% (19)19 / 222 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Multi email Question Checkbox Group required and Multi email required
Retry 1 • Initial Attempt |
0.45% (1)1 / 222 runfailed over last 7 days |
5.86% (13)13 / 222 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
reserveSlots had a bug where typescript would hide a type check failure, this caused a crash for some users when another slot was reserved.
https://calcom.sentry.io/issues/4914931829/?project=4504055091625984&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=1h&stream_index=0