-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more og avatar fixes #13817
fix: more og avatar fixes #13817
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
@@ -83,7 +83,7 @@ export const SEO_IMG_DEFAULT = `${CAL_URL}/og-image.png`; | |||
// parameters you pass to the /api/social/og/image endpoint, you wrap them in encodeURIComponent | |||
// as well, otherwise the URL won't be valid. | |||
export const SEO_IMG_OGIMG = `${CAL_URL}/_next/image?w=1200&q=100&url=${encodeURIComponent( | |||
"/api/social/og/image" | |||
`${CAL_URL}/api/social/og/image` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was it ._.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
part of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, absolute URL should fix most issues, getUserAvatar the rest
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
No failed tests 🎉 |
What does this PR do?
refs #13777
follow up to #13790
Hopefully this cover ups and fixes @PeerRich profile edge-case as well
Type of change
How should this be tested?
Mandatory Tasks