Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more og avatar fixes #13817

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: more og avatar fixes #13817

merged 1 commit into from
Feb 22, 2024

Conversation

zomars
Copy link
Member

@zomars zomars commented Feb 22, 2024

What does this PR do?

refs #13777

follow up to #13790

Hopefully this cover ups and fixes @PeerRich profile edge-case as well

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • On preview check OG image is rendered correctly.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 1:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Feb 22, 2024 1:11am

@zomars zomars requested a review from a team February 22, 2024 01:09
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added api area: API, enterprise API, access token, OAuth core area: core, team members only foundation labels Feb 22, 2024
@@ -83,7 +83,7 @@ export const SEO_IMG_DEFAULT = `${CAL_URL}/og-image.png`;
// parameters you pass to the /api/social/og/image endpoint, you wrap them in encodeURIComponent
// as well, otherwise the URL won't be valid.
export const SEO_IMG_OGIMG = `${CAL_URL}/_next/image?w=1200&q=100&url=${encodeURIComponent(
"/api/social/og/image"
`${CAL_URL}/api/social/og/image`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was it ._.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of it

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, absolute URL should fix most issues, getUserAvatar the rest

@emrysal emrysal enabled auto-merge (squash) February 22, 2024 01:15
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 22, 2024

No failed tests 🎉

@emrysal emrysal merged commit ac6ac14 into main Feb 22, 2024
40 checks passed
@emrysal emrysal deleted the fix/og-avatars branch February 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only foundation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants