Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New Team Members Join Org as OWNER/ADMIN #13822

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

SomayChauhan
Copy link
Member

What does this PR do?

Fixes #13773

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 22, 2024
Copy link

vercel bot commented Feb 22, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added consumer enterprise area: enterprise, audit log, organisation, SAML, SSO High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Feb 22, 2024
@graphite-app graphite-app bot requested a review from a team February 22, 2024 09:11
Copy link

graphite-app bot commented Feb 22, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/22/24)

1 label was added based on Keith Williams's automation, 'Add community label'

A Graphite automation took an action on this PR • (02/22/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@@ -285,7 +285,7 @@ export async function createNewUsersConnectToOrgIfExists({
data: {
teamId: parentId,
userId: createdUser.id,
role: input.role as MembershipRole,
role: MembershipRole.MEMBER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So earlier if you invite someone to team as admin then we would also assign admin role of complete org too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this fix 🙏

@CarinaWolli CarinaWolli merged commit 5f95a4d into calcom:main Feb 22, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer enterprise area: enterprise, audit log, organisation, SAML, SSO High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3171] New Team Members Join Org as OWNER/ADMIN
3 participants