Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hover state #13862

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix: hover state #13862

merged 2 commits into from
Feb 27, 2024

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@graphite-app graphite-app bot requested a review from a team February 26, 2024 11:55
Copy link
Contributor

github-actions bot commented Feb 26, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 2:11pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 2:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Feb 27, 2024 2:11pm
qa ⬜️ Ignored (Inspect) Feb 27, 2024 2:11pm

Copy link

graphite-app bot commented Feb 26, 2024

Graphite Automations

A Graphite automation took an action on this PR • (02/26/24)

1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer'

Copy link
Contributor

github-actions bot commented Feb 26, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Feb 26, 2024

Current Playwright Test Results Summary

✅ 452 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/27/2024 02:30:54pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: da51314

Started: 02/27/2024 02:20:19pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking/selectQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Select Question and Long text Question Select and Long text not required
Retry 1Initial Attempt
0.52% (1) 1 / 193 run
failed over last 7 days
6.74% (13) 13 / 193 runs
flaked over last 7 days

📄   apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Short text question Radio and Short text not required
Retry 2Retry 1Initial Attempt
0.51% (1) 1 / 197 run
failed over last 7 days
6.09% (12) 12 / 197 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 2Retry 1Initial Attempt
1.53% (3) 3 / 196 runs
failed over last 7 days
9.69% (19) 19 / 196 runs
flaked over last 7 days

📄   apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group required and Long text required
Retry 1Initial Attempt
0% (0) 0 / 193 runs
failed over last 7 days
6.74% (13) 13 / 193 runs
flaked over last 7 days
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Radio group Question Checkbox Group required and Radio group required
Retry 1Initial Attempt
0% (0) 0 / 192 runs
failed over last 7 days
5.21% (10) 10 / 192 runs
flaked over last 7 days

📄   apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Phone required and Address not required
Retry 1Initial Attempt
0% (0) 0 / 202 runs
failed over last 7 days
4.46% (9) 9 / 202 runs
flaked over last 7 days

📄   apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox group Question Multiple Email and checkbox group not required
Retry 1Initial Attempt
1.02% (2) 2 / 196 runs
failed over last 7 days
8.67% (17) 17 / 196 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and checkbox Question Multiple Email required and checkbox required
Retry 1Initial Attempt
0% (0) 0 / 194 runs
failed over last 7 days
6.70% (13) 13 / 194 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Long text Question Multiple Email required and Long text required
Retry 1Initial Attempt
0.52% (1) 1 / 193 run
failed over last 7 days
2.59% (5) 5 / 193 runs
flaked over last 7 days
Booking With Multiple Email Question and Each Other Question Booking With Multiple email Question and phone Question Multiple email required and Phone required
Retry 1Initial Attempt
0% (0) 0 / 188 runs
failed over last 7 days
7.45% (14) 14 / 188 runs
flaked over last 7 days

📄   apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Team Invitation (non verified)
Retry 1Initial Attempt
0.50% (1) 1 / 201 run
failed over last 7 days
7.46% (15) 15 / 201 runs
flaked over last 7 days

📄   apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and Number Question Address required and Number required
Retry 1Initial Attempt
0% (0) 0 / 197 runs
failed over last 7 days
7.61% (15) 15 / 197 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
15.76% (32) 32 / 203 runs
failed over last 7 days
50.25% (102) 102 / 203 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 201 runs
failed over last 7 days
15.92% (32) 32 / 201 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-0.50% (-1) -1 / 200 runs
failed over last 7 days
50% (100) 100 / 200 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-93.07% (-94) -94 / 101 runs
failed over last 7 days
94.06% (95) 95 / 101 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-94.95% (-94) -94 / 99 runs
failed over last 7 days
94.95% (94) 94 / 99 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithwillcode keithwillcode enabled auto-merge (squash) February 27, 2024 10:50
@keithwillcode keithwillcode added this to the v3.9 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants