fix: infinite rendering in event setup tab #13877
Merged
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite AutomationsA Graphite automation took an action on this PR • (02/26/24)1 reviewer was added based on Keith Williams's automation, 'Add consumer team as reviewer' |
Current Playwright Test Results Summary✅ 448 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/26/2024 09:37:13pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 27e7a64 Started: 02/26/2024 09:26:17pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Long Text required and Address not required
Retry 1 • Initial Attempt |
0.52% (1)1 / 192 runfailed over last 7 days |
7.29% (14)14 / 192 runsflaked over last 7 days |
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and Radio group Question Long Text required and Radio group not required
Retry 1 • Initial Attempt |
0.53% (1)1 / 188 runfailed over last 7 days |
8.51% (16)16 / 188 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Phone Question Checkbox Group required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 196 runsfailed over last 7 days |
6.12% (12)12 / 196 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Long text Question Checkbox Group required and Long text required
Retry 1 • Initial Attempt |
0% (0)0 / 195 runsfailed over last 7 days |
5.13% (10)10 / 195 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0.53% (1)1 / 190 runfailed over last 7 days |
40.53% (77)77 / 190 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration when enabling Stripe, team credentialId is included
Retry 1 • Initial Attempt |
0% (0)0 / 196 runsfailed over last 7 days |
1.53% (3)3 / 196 runsflaked over last 7 days |
📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Address Question and Each Other Question Booking With Address Question and Long text Question Address and Long Text not required
Retry 2 • Retry 1 • Initial Attempt |
0.50% (1)1 / 201 runfailed over last 7 days |
4.48% (9)9 / 201 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Number Question Address and Number not required
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
3.02% (6)6 / 199 runsflaked over last 7 days |
|
Booking With Address Question and Each Other Question Booking With Address Question and Phone Question Address required and Phone required
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
5.03% (10)10 / 199 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
2.01% (4)4 / 199 runsflaked over last 7 days |
📄 apps/web/playwright/booking/multipleEmailQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Multiple Email required and Radio group required
Retry 1 • Initial Attempt |
0% (0)0 / 190 runsfailed over last 7 days |
7.89% (15)15 / 190 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
0.50% (1)1 / 202 runfailed over last 7 days |
9.41% (19)19 / 202 runsflaked over last 7 days |
📄 apps/web/playwright/eventType/limit-tab.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Limits Tab - Event Type Check the functionalities of the Limits Tab
Retry 1 • Initial Attempt |
0.51% (1)1 / 197 runfailed over last 7 days |
2.54% (5)5 / 197 runsflaked over last 7 days |
📄 apps/web/playwright/insights.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should be able to go to insights as admins
Retry 1 • Initial Attempt |
0% (0)0 / 198 runsfailed over last 7 days |
3.03% (6)6 / 198 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 205 runsfailed over last 7 days |
51.22% (105)105 / 205 runsflaked over last 7 days |
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
16.10% (33)33 / 205 runsfailed over last 7 days |
49.76% (102)102 / 205 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 205 runsfailed over last 7 days |
36.59% (75)75 / 205 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 203 runsfailed over last 7 days |
51.72% (105)105 / 203 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-101.02% (-99)-99 / 98 runsfailed over last 7 days |
102.04% (100)100 / 98 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-103.13% (-99)-99 / 96 runsfailed over last 7 days |
103.13% (99)99 / 96 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue) Infinite rendering bug when organizer phone selected or attendee
Before:=
Screen.Recording.2024-02-27.at.2.44.50.AM.mov
Type of change