Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not refund payments when cancelling bookings #13924

Merged
merged 5 commits into from Mar 13, 2024

Conversation

joeauyeung
Copy link
Contributor

What does this PR do?

This PR removes the logic to refunding bookings on cancel. Ideally this should happen via a user action. Will follow up with a way to do this via the UI.

Fixes #13916

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a paid booking
  • Cancel the booking
  • On the payment app portal, the booking should have not been refunded

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@joeauyeung joeauyeung requested a review from a team February 28, 2024 19:03
@github-actions github-actions bot added billing area: billing, stripe, payments, paypal, get paid 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Feb 28, 2024
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

deploysentinel bot commented Feb 28, 2024

Current Playwright Test Results Summary

✅ 50 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/13/2024 09:45:18pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 4d5a58d

Started: 03/13/2024 09:43:44pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can add a new email as a secondary email
Retry 1Initial Attempt
0% (0) 0 / 224 runs
failed over last 7 days
0.45% (1) 1 / 224 run
flaked over last 7 days
Update Profile Newly added secondary email should show as Unverified
Retry 1Initial Attempt
0% (0) 0 / 224 runs
failed over last 7 days
12.95% (29) 29 / 224 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Feb 28, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Mar 4, 2024
@keithwillcode keithwillcode added this to the v3.9 milestone Mar 4, 2024
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 8:11pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 8:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 8:11pm
qa ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 8:11pm

CarinaWolli
CarinaWolli previously approved these changes Mar 13, 2024
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarinaWolli CarinaWolli enabled auto-merge (squash) March 13, 2024 21:42
@CarinaWolli CarinaWolli merged commit 802fbdf into main Mar 13, 2024
37 of 38 checks passed
@CarinaWolli CarinaWolli deleted the disable-refund-when-cancelling-booking branch March 13, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billing area: billing, stripe, payments, paypal, get paid consumer core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3240] Stripe: Don't auto-issue refunds when a user cancels
4 participants