feat: select team members to receive emails #13957

asadath1395 · 2024-03-02T10:45:17Z

What does this PR do?

Fixes #13641

https://www.loom.com/share/0b953b7899224b28977f2a10f6f8e5a7?sid=56f772fd-00ad-4b12-ba5f-1251d0704998

Type of change

New feature (non-breaking change which adds functionality)

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2024-03-02T10:45:23Z

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-03-02T10:45:28Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-03-02T10:50:13Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/02/24)

1 label was added to this PR based on Keith Williams's automation.

github-actions · 2024-03-02T10:54:56Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/apps/[slug]/[...pages]`	`560.47 KB`	750.02 KB	214.29% (🟡 +0.56%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

… routing form updates to

…d of only the current team where the routing form is created

CarinaWolli · 2024-03-05T13:50:20Z

@asadath1395 can you fix the type errors please 🙏

asadath1395 · 2024-03-05T14:04:43Z

@CarinaWolli The type errors are not from my changes, since i touched that file, its showing already existing ones i think. Strange😬. Anyways onto fixing them.

…asadath1395/cal.com into add-team-members-receive-emails

asadath1395 · 2024-03-05T17:07:34Z

@CarinaWolli I am seeing strange behaviour, the moment i fix something in the imports, the other file starts throwing more type errors, any idea on why that is happening? Also yarn run type-check doesn't throw error but yarn run type-check:ci throws these weird type errors.

packages/features/eventtypes/components/CheckedTeamSelect.tsx

…asadath1395/cal.com into add-team-members-receive-emails

joeauyeung

Thanks for your contribution @asadath1395. I left some non-blocking comments. One question I have is if no member is assigned should we default sending the form to the organizer or just leave it as is @CarinaWolli?

packages/app-store/routing-forms/trpc/response.handler.ts

joeauyeung · 2024-03-18T17:29:41Z

packages/trpc/server/routers/viewer/teams/listMembers.handler.ts

@@ -36,6 +36,8 @@ export const listMembersHandler = async ({ ctx, input }: ListMembersOptions) =>
              id: true,
              name: true,
              username: true,
+              email: true,


When submitting the routing form we query the DB again for the user email. Let's not include the user email in the list member's query then.

joeauyeung · 2024-03-18T17:36:11Z

packages/app-store/routing-forms/components/SingleForm.tsx

+  useEffect(() => {
+    if (form.teamId && form.settings?.sendUpdatesTo?.length && teamMembers?.length) {
+      let sendToAll = true;
+      teamMembers.forEach((member) => {
+        if (!form.settings?.sendUpdatesTo?.includes(member.id)) {
+          sendToAll = false;
+          return;
+        }
+      });
+      setAssignAllTeamMembers(sendToAll);
+      setSelectedMembers(
+        form.settings.sendUpdatesTo.map((userId) => ({
+          isFixed: true,
+          userId: userId,
+          priority: 1,
+        }))
+      );
+    }
+  }, [form.teamId, form.settings?.sendUpdatesTo?.length, teamMembers?.length]);


Could we instead add to the form a sendToAll and a sendUpdatesTo field?

joeauyeung · 2024-03-18T17:37:30Z

packages/app-store/routing-forms/components/SingleForm.tsx

+  const { data: teamMembers } = form.teamId
+    ? trpc.viewer.teams.listMembers.useQuery({ teamIds: [form.teamId] })
+    : { data: [] };


If we are querying the team members everytime the form has a teamId can we move this to server side and include it in the formQuery.handler?

CarinaWolli · 2024-03-18T19:10:45Z

Thanks for your contribution @asadath1395. I left some non-blocking comments. One question I have is if no member is assigned should we default sending the form to the organizer or just leave it as is @CarinaWolli?

I think it's fine to not send an email if no member is selected

But we need to add a heading to this, right now we don't mention anywhere that this is for email sending:

…m-members-receive-emails

…y.handler

…asadath1395/cal.com into add-team-members-receive-emails

asadath1395 · 2024-03-20T10:05:22Z

Thanks for your contribution @asadath1395. I left some non-blocking comments. One question I have is if no member is assigned should we default sending the form to the organizer or just leave it as is @CarinaWolli?

I think it's fine to not send an email if no member is selected

But we need to add a heading to this, right now we don't mention anywhere that this is for email sending:

I have added a heading

asadath1395 · 2024-03-20T10:07:48Z

@joeauyeung Thanks for taking a look at this PR. I have addressed all your comments, mind reviewing the PR again. Thanks

CarinaWolli

Great work, looks good 🙌🏻 Thank you for your contribution 🙏

Add UI to select members to receive emails in routing form

45ad054

graphite-app bot added the community Created by Linear-GitHub Sync label Mar 2, 2024

graphite-app bot requested a review from a team March 2, 2024 10:45

asadath1395 marked this pull request as draft March 2, 2024 10:45

github-actions bot added consumer Medium priority Created by Linear-GitHub Sync routing-forms area: routing forms, routing, forms ui area: UI, frontend, button, form, input 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Mar 2, 2024

asadath1395 added 4 commits March 3, 2024 18:24

Add backend changes to support frontend to select team members to get…

e49a9b1

… routing form updates to

Merge with upstream

93c8f82

Fix type error

23880dd

Fix all the members of all the teams the user is part of shown instea…

6b39816

…d of only the current team where the routing form is created

asadath1395 marked this pull request as ready for review March 4, 2024 08:40

keithwillcode added this to the v3.9 milestone Mar 4, 2024

asadath1395 and others added 3 commits March 5, 2024 08:55

Fix type error

9b852c8

Merge branch 'main' into add-team-members-receive-emails

837dbba

Merge branch 'main' into add-team-members-receive-emails

c841056

keithwillcode modified the milestones: v3.9, v4.0 Mar 5, 2024

asadath1395 added 2 commits March 5, 2024 22:05

Merge with upstream

2859d7a

Merge branch 'add-team-members-receive-emails' of https://github.com/…

87c2167

…asadath1395/cal.com into add-team-members-receive-emails

Merge branch 'main' into add-team-members-receive-emails

46d7da0

fix type error

a6d75dc

CarinaWolli reviewed Mar 14, 2024

View reviewed changes

packages/features/eventtypes/components/CheckedTeamSelect.tsx Show resolved Hide resolved

asadath1395 and others added 3 commits March 15, 2024 15:24

Merge with upstream and fix merge conflicts

e8b25e9

Merge branch 'add-team-members-receive-emails' of https://github.com/…

8b7170d

…asadath1395/cal.com into add-team-members-receive-emails

Merge branch 'main' into add-team-members-receive-emails

6b7a554

joeauyeung reviewed Mar 18, 2024

View reviewed changes

asadath1395 and others added 8 commits March 19, 2024 18:12

Merge branch 'main' of https://github.com/calcom/cal.com into add-tea…

3484e6e

…m-members-receive-emails

Fix review comment: only include emails

8493678

Remove listMembers trpc call in frontend and get the data in formQuer…

81e4d1b

…y.handler

Address review comments

319cf6d

Merge branch 'add-team-members-receive-emails' of https://github.com/…

2352550

…asadath1395/cal.com into add-team-members-receive-emails

Merge branch 'main' into add-team-members-receive-emails

47cc320

Remove unrelated changes

4d2cfb0

Merge branch 'add-team-members-receive-emails' of https://github.com/…

79d9346

…asadath1395/cal.com into add-team-members-receive-emails

asadath1395 requested review from joeauyeung and CarinaWolli March 20, 2024 10:07

Update SingleForm.tsx

5206fd8

CarinaWolli approved these changes Mar 21, 2024

View reviewed changes

Merge branch 'main' into add-team-members-receive-emails

7e6c566

CarinaWolli enabled auto-merge (squash) March 21, 2024 14:56

CarinaWolli merged commit 61a8543 into calcom:main Mar 21, 2024
30 of 38 checks passed

dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024

keithwillcode modified the milestones: v4.1, v4.0 Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: select team members to receive emails #13957

feat: select team members to receive emails #13957

asadath1395 commented Mar 2, 2024 •

edited

vercel bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024 •

edited

graphite-app bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024 •

edited

CarinaWolli commented Mar 5, 2024

asadath1395 commented Mar 5, 2024

asadath1395 commented Mar 5, 2024

joeauyeung left a comment

joeauyeung Mar 18, 2024

asadath1395 Mar 20, 2024

joeauyeung Mar 18, 2024

asadath1395 Mar 20, 2024

joeauyeung Mar 18, 2024

asadath1395 Mar 20, 2024

CarinaWolli commented Mar 18, 2024

asadath1395 commented Mar 20, 2024

asadath1395 commented Mar 20, 2024

CarinaWolli left a comment

feat: select team members to receive emails #13957

feat: select team members to receive emails #13957

Conversation

asadath1395 commented Mar 2, 2024 • edited

What does this PR do?

Type of change

Mandatory Tasks

vercel bot commented Mar 2, 2024

github-actions bot commented Mar 2, 2024 • edited

graphite-app bot commented Mar 2, 2024

Graphite Automations

github-actions bot commented Mar 2, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

One Page Changed Size

CarinaWolli commented Mar 5, 2024

asadath1395 commented Mar 5, 2024

asadath1395 commented Mar 5, 2024

joeauyeung left a comment

Choose a reason for hiding this comment

joeauyeung Mar 18, 2024

Choose a reason for hiding this comment

asadath1395 Mar 20, 2024

Choose a reason for hiding this comment

joeauyeung Mar 18, 2024

Choose a reason for hiding this comment

asadath1395 Mar 20, 2024

Choose a reason for hiding this comment

joeauyeung Mar 18, 2024

Choose a reason for hiding this comment

asadath1395 Mar 20, 2024

Choose a reason for hiding this comment

CarinaWolli commented Mar 18, 2024

asadath1395 commented Mar 20, 2024

asadath1395 commented Mar 20, 2024

CarinaWolli left a comment

Choose a reason for hiding this comment

asadath1395 commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited

github-actions bot commented Mar 2, 2024 •

edited