Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to remove single recurring instance from gCal #13960

Merged

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Fixes #13827

Before:

Screen.Recording.2024-03-02.at.10.16.49.PM.mov

Instances are not referenced properly, causing the unintended deletion of some other instance when one is deleted

After:

Screen.Recording.2024-03-02.at.10.26.20.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected

@graphite-app graphite-app bot requested a review from a team March 2, 2024 17:09
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 2, 2024
Copy link

vercel bot commented Mar 2, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync recurring events Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Mar 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/02/24)

1 label was added to this PR based on Keith Williams's automation.

@Amit91848 Amit91848 changed the title fix: unable to remove single recurring instance from fix: unable to remove single recurring instance from gCal Mar 2, 2024
Copy link
Contributor

github-actions bot commented Mar 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v3.9 milestone Mar 4, 2024
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, tested and works 🙌🏻 Thank you 🙏

@CarinaWolli CarinaWolli merged commit 0972307 into calcom:main Mar 6, 2024
31 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync recurring events Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3196] Cancelling 1 instance of a recurring event is not removing it from my Google cal
3 participants