fix: Email Embed for team event types #13990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
consumer
emails
Udit-takkar
commented
Mar 6, 2024
Comment on lines
+489
to
+490
| data-testid="see_all_available_times" | ||
| href={`${eventType.bookerUrl}/${calLink}`} |
There was a problem hiding this comment.
fixed preview url
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Udit-takkar
commented
Mar 6, 2024
| @@ -721,8 +739,9 @@ const EmbedTypeCodeAndPreviewDialogContent = ({ | |||
| {eventTypeData?.eventType && embedType === "email" ? ( | |||
| <EmailEmbed | |||
| eventType={eventTypeData?.eventType} | |||
| username={data?.user.username as string} | |||
| username={teamSlug ?? (data?.user.username as string)} | |||
There was a problem hiding this comment.
Need to pass teamSlug and isTeamEvent to make useScheduledForEvent get event type details and slots
Udit-takkar
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/06/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sean-brydon
approved these changes
Mar 6, 2024
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/06/2024 10:00:58am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cf0343b Started: 03/06/2024 09:55:19am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1 • Initial Attempt |
0% (0)0 / 191 runsfailed over last 7 days |
1.57% (3)3 / 191 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 207 runsfailed over last 7 days |
0.48% (1)1 / 207 runflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Signup with valid (non premium) username
Retry 1 • Initial Attempt |
2.42% (5)5 / 207 runsfailed over last 7 days |
2.90% (6)6 / 207 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
prefill -- future logged in
Retry 1 • Initial Attempt |
0% (0)0 / 197 runsfailed over last 7 days |
2.54% (5)5 / 197 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
2.44% (5)5 / 205 runsfailed over last 7 days |
6.83% (14)14 / 205 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity tests Schedule listing
Retry 1 • Initial Attempt |
0% (0)0 / 206 runsfailed over last 7 days |
1.94% (4)4 / 206 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13679
Type of change