fix: Implement new avatars in insights #13996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
zomars
previously approved these changes
Mar 6, 2024
|
No failed tests 🎉 |
|
@emrysal we have some typing issues |
emrysal
commented
Mar 7, 2024
|
|
||
| const result = bookingsFromTeam.map((booking) => { | ||
| return { | ||
| userId: booking.userId, | ||
| user: userHashMap.get(booking.userId), | ||
| // We know with 100% certainty that userHashMap.get(...) will retrieve a user |
There was a problem hiding this comment.
Remove | undefined from type inference for user:
PeerRich
added
Medium priority
zomars
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Little bit of code cleanup, typescript & support of avatarUrl db column