Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock event types for org users #14000

Merged
merged 34 commits into from Mar 14, 2024
Merged

Conversation

sean-brydon
Copy link
Member

fixes: CAL-3152 #13716

Adds the ability for org customers to stop users creating events on their own acme.cal.com/[user] profile and only rely on managed event types

Loom: https://www.loom.com/share/9dd0f8704d7e42a0891f50deffb9bf17

Copy link

linear bot commented Mar 7, 2024

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:54am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:54am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:54am
qa ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 8:54am

@graphite-app graphite-app bot requested a review from a team March 7, 2024 08:58
@github-actions github-actions bot added the ❗️ migrations contains migration files label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 7, 2024
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two more small things that are blocking 🙏

We need to disable the toggle inside event type settings too
Screenshot 2024-03-11 at 11 22 51 AM

@@ -810,6 +813,7 @@ const CTA = ({ data }: { data: GetByViewerResponse }) => {

const profileOptions = data.profiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to disable the CreateButton if we don't have any profileOptions. Now I am getting an error when clicking on the 'New' button Uncaught TypeError: Cannot read properties of undefined (reading 'slug')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never even thought of this - nice spot

CarinaWolli
CarinaWolli previously approved these changes Mar 11, 2024
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, nice work 👏🏻

@CarinaWolli
Copy link
Member

@sean-brydon can you fix the merge conflicts?

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve after fixing merge conflicts

@CarinaWolli CarinaWolli enabled auto-merge (squash) March 13, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants