fix: slugify from creating double+ dashes #14002
Conversation
github-actions
bot
added
the
booking-page
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
High priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
packages/lib/slugify.test.ts
Outdated
| it.skip("should remove unicode and emoji characters", () => { | ||
| expect(slugify("Hello 📚🕯️®️ There")).toEqual("hello---------there"); |
There was a problem hiding this comment.
this old test case too many dashes in expected value
There was a problem hiding this comment.
Do we want to allow these many consecutive dashes?
There was a problem hiding this comment.
Oh i missed that as its being skipped let me see if i can fix the test
No this new slugify will only allow one dash in a row
There was a problem hiding this comment.
Fixed test for emojis - unicode seems to be a bit harder to remove in this instance
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
No failed tests 🎉 |
…e-triple-dashes-getting-in-to-public-booking-links' into sean/cal-3260-double-triple-dashes-getting-in-to-public-booking-links
…n-to-public-booking-links
|
i was just about to open an issue for this lol. great work! |
Udit-takkar
deleted the
sean/cal-3260-double-triple-dashes-getting-in-to-public-booking-links
branch
fixes: #13980
Before:
"Hello - World 123_ !@# Test 456 789" -> "hello---world-123----test-456-789"
Now
"Hello - World 123_ !@# Test 456 789" ->""hello-world-123-test-456-789"