-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add future team members toggle #14008
fix: add future team members toggle #14008
Conversation
fix: add future team members toggle
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/07/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/07/24)1 label was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
packages/trpc/server/routers/loggedInViewer/updateProfile.handler.ts
Outdated
Show resolved
Hide resolved
packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block this PR but was updateNewTeamMemberEventTypes
in packages\lib\server\queries\teams\index.ts
not working properly? It seems like it was only being called in inviteMember.handler
were there other pathways for inviting team/org members we were missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block this PR but was updateNewTeamMemberEventTypes
in packages\lib\server\queries\teams\index.ts
not working properly? It seems like it was only being called in inviteMember.handler
were there other pathways for inviting team/org members we were missing?
This PR addressed the scenario in which a new team member is added directly to a sub-team (user doesn't already exist within the organization). In this case, the function Since we are adding the user to the organization, they are not given the option to accept or decline, meaning that the |
What does this PR do?
Fixes # (issue)