Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add future team members toggle #14008

Merged

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Mar 7, 2024

What does this PR do?

Fixes # (issue)

image_6487327

fix: add future team members toggle
Copy link

vercel bot commented Mar 7, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team March 7, 2024 10:39
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Mar 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/07/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich added 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync labels Mar 7, 2024
@PeerRich PeerRich added this to the v3.9 milestone Mar 7, 2024
@Udit-takkar Udit-takkar requested a review from a team March 7, 2024 14:00
@Udit-takkar Udit-takkar enabled auto-merge (squash) March 7, 2024 15:30
Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this PR but was updateNewTeamMemberEventTypes in packages\lib\server\queries\teams\index.ts not working properly? It seems like it was only being called in inviteMember.handler were there other pathways for inviting team/org members we were missing?

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this PR but was updateNewTeamMemberEventTypes in packages\lib\server\queries\teams\index.ts not working properly? It seems like it was only being called in inviteMember.handler were there other pathways for inviting team/org members we were missing?

@Udit-takkar Udit-takkar merged commit 5c8e048 into calcom:main Mar 7, 2024
29 of 37 checks passed
@SomayChauhan
Copy link
Member Author

SomayChauhan commented Mar 7, 2024

I don't want to block this PR but was updateNewTeamMemberEventTypes in packages\lib\server\queries\teams\index.ts not working properly? It seems like it was only being called in inviteMember.handler were there other pathways for inviting team/org members we were missing?

This PR addressed the scenario in which a new team member is added directly to a sub-team (user doesn't already exist within the organization). In this case, the function handleExistingUsersInvites where updateNewTeamMemberEventTypes is called does not execute.

Since we are adding the user to the organization, they are not given the option to accept or decline, meaning that the acceptOrLeave.handler.ts will also not be called. We are calling updateNewTeamMemberEventTypes once the user has completed onboarding because only then have they set up their availability and timezone, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants