Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create team events using admin token #14044

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

asadath1395
Copy link
Contributor

@asadath1395 asadath1395 commented Mar 9, 2024

What does this PR do?

Fixes #9119

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a new event using the API, i used the below payload
{
    "title": "Hello World",
    "slug": "hello-world",
    "length": 30,
    "hidden": false,
    "position": 0,
    "eventName": null,
    "timeZone": null,
    "scheduleId": 5,
    "periodType": "UNLIMITED",
    "periodDays": null,
    "periodCountCalendarDays": false,
    "requiresConfirmation": false,
    "disableGuests": false,
    "hideCalendarNotes": false,
    "minimumBookingNotice": 120,
    "beforeEventBuffer": 0,
    "afterEventBuffer": 0,
    "price": 0,
    "currency": "usd",
    "slotInterval": null,
    "successRedirectUrl": null,
    "description": "A test event type",
    "teamId": 1,
    "userId": 13
}

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 9, 2024
Copy link

vercel bot commented Mar 9, 2024

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team March 9, 2024 12:13
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added api area: API, enterprise API, access token, OAuth event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync platform Anything related to our platform plan 🐛 bug Something isn't working labels Mar 9, 2024
@graphite-app graphite-app bot requested a review from a team March 9, 2024 12:13
Copy link

graphite-app bot commented Mar 9, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/09/24)

1 label was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (03/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/availability 436.22 KB 624.62 KB 178.46% (🟢 -0.33%)
/settings/organizations/members 438.57 KB 626.97 KB 179.13% (🟡 +1.32%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@asadath1395
Copy link
Contributor Author

Quick question: As an admin, shouldn't i not see all the teams and its events in the UI?

@PeerRich PeerRich added this to the v3.9 milestone Mar 11, 2024
@emrysal emrysal enabled auto-merge (squash) March 12, 2024 16:16
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@emrysal emrysal merged commit 54db9a4 into calcom:main Mar 12, 2024
29 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working community Created by Linear-GitHub Sync event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-1787] Impossible to create Team Event Type with admin token
3 participants