feat: support for platform wide webhooks #14092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
consumer
High priority
SomayChauhan
force-pushed
the
feat/support-for-platform-wide-webhooks
branch
from
602e019
to
69513b1
Compare
SomayChauhan
force-pushed
the
feat/support-for-platform-wide-webhooks
branch
from
2ee4320
to
7ecb109
Compare
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/15/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/15/24)1 label was added to this PR based on Keith Williams's automation. |
CarinaWolli
requested changes
Mar 15, 2024
|
|
||
| if (input.eventTypeId) { | ||
| andCondition.push({ eventTypeId: input.eventTypeId }); | ||
| } else if (input.teamId) { | ||
| andCondition.push({ teamId: input.teamId }); | ||
| } else if (ctx.user.role == "ADMIN") { | ||
| andCondition.push({ platform: true }); |
There was a problem hiding this comment.
with this, the ADMIN won't be able to delete any of their other event types anymore
| @@ -127,7 +143,6 @@ const WebhooksList = ({ webhooksByViewer }: { webhooksByViewer: WebhooksByViewer | |||
| <WebhookListItem | |||
| key={webhook.id} | |||
| webhook={webhook} | |||
| readOnly={group.metadata?.readOnly ?? false} | |||
|
@SomayChauhan can you take a look at the type error? |
fixed 👍 |
CarinaWolli
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LOOM
Fixes #13587
Type of change
How should this be tested?
Mandatory Tasks