fix: rescheduling in round robin #14109
Merged
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Udit-takkar
commented
Mar 15, 2024
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/15/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
commented
Mar 15, 2024
| @@ -388,8 +389,7 @@ export default class EventManager { | |||
|
|
|||
| log.debug("RescheduleOrganizerChanged: Creating Event and Meeting for for new booking"); | |||
|
|
|||
| const newEvent = { ...evt, destinationCalendar: newDestinationCalendar }; | |||
| const createdEvent = await this.create(newEvent); | |||
| const createdEvent = await this.create(originalEvt); | |||
There was a problem hiding this comment.
create function updates the videoCallData in evt(Calendar event object) like
evt.videoCallData = { ... }
but in reschedule function we passed copy of event object to create function in this line which updated the copy of event but not the original event
github-actions
bot
added
bookings
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/21/2024 11:34:28am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b172b90 Started: 03/21/2024 11:31:51am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
8.84% (16)16 / 181 runsfailed over last 7 days |
23.76% (43)43 / 181 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
3.43% (6)6 / 175 runsfailed over last 7 days |
27.43% (48)48 / 175 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.65% (3)3 / 182 runsfailed over last 7 days |
49.45% (90)90 / 182 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-101.12% (-90)-90 / 89 runsfailed over last 7 days |
101.12% (90)90 / 89 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-101.12% (-90)-90 / 89 runsfailed over last 7 days |
101.12% (90)90 / 89 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-100% (-89)-89 / 89 runsfailed over last 7 days |
101.12% (90)90 / 89 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-102.27% (-90)-90 / 88 runsfailed over last 7 days |
102.27% (90)90 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-102.27% (-90)-90 / 88 runsfailed over last 7 days |
102.27% (90)90 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-102.27% (-90)-90 / 88 runsfailed over last 7 days |
102.27% (90)90 / 88 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-102.27% (-90)-90 / 88 runsfailed over last 7 days |
102.27% (90)90 / 88 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization nonexisting user is invited to Org
Retry 1 • Initial Attempt |
2.72% (5)5 / 184 runsfailed over last 7 days |
4.89% (9)9 / 184 runsflaked over last 7 days |
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization nonexisting user is invited to a team inside organization
Retry 1 • Initial Attempt |
1.65% (3)3 / 182 runsfailed over last 7 days |
9.34% (17)17 / 182 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 181 runsfailed over last 7 days |
30.94% (56)56 / 181 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
2.20% (4)4 / 182 runsfailed over last 7 days |
39.01% (71)71 / 182 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14108
Requirement/Documentation
Type of change