fix: date picker arrow positioning #14129
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
ui
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 13 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/18/2024 06:27:02pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 1557fb5 Started: 03/18/2024 06:26:01pm UTC
|
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1% (2)2 / 201 runsfailed over last 7 days |
44.78% (90)90 / 201 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-82.57% (-90)-90 / 109 runsfailed over last 7 days |
82.57% (90)90 / 109 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-83.33% (-90)-90 / 108 runsfailed over last 7 days |
83.33% (90)90 / 108 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-83.18% (-89)-89 / 107 runsfailed over last 7 days |
83.18% (89)89 / 107 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-81.48% (-88)-88 / 108 runsfailed over last 7 days |
82.41% (89)89 / 108 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-83.18% (-89)-89 / 107 runsfailed over last 7 days |
83.18% (89)89 / 107 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-83.18% (-89)-89 / 107 runsfailed over last 7 days |
83.18% (89)89 / 107 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-83.18% (-89)-89 / 107 runsfailed over last 7 days |
83.18% (89)89 / 107 runsflaked over last 7 days |
joeauyeung
requested changes
Mar 18, 2024
There was a problem hiding this comment.
So far so good @Udit-takkar.
Heads up on medium and small screen sizes there's a jump between March to April and May to June.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
joeauyeung
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Awesome work @Udit-takkar
Tested on iPad Air and Pixel 7 screen sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14122
Screen.Recording.2024-03-18.at.7.22.34.AM.mov
Type of change