Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve apple calendar message #14139

Merged
merged 3 commits into from Mar 19, 2024
Merged

Conversation

Udit-takkar
Copy link
Contributor

What does this PR do?

Fixes #13328 (comment)

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

@graphite-app graphite-app bot requested a review from a team March 19, 2024 10:11
@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar foundation Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 19, 2024
@Udit-takkar Udit-takkar changed the title Fix/apple calendar message chore: improve apple calendar message Mar 19, 2024
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:17pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:17pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:17pm
qa ⬜️ Ignored (Inspect) Mar 19, 2024 2:17pm

Copy link

graphite-app bot commented Mar 19, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Mar 19, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Mar 19, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/19/2024 02:32:13pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a72b6aa

Started: 03/19/2024 02:28:23pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
9.22% (19) 19 / 206 runs
failed over last 7 days
22.82% (47) 47 / 206 runs
flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
6.37% (13) 13 / 204 runs
failed over last 7 days
25% (51) 51 / 204 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
7.69% (17) 17 / 221 runs
failed over last 7 days
30.77% (68) 68 / 221 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization
Retry 1Initial Attempt
0.48% (1) 1 / 208 run
failed over last 7 days
10.10% (21) 21 / 208 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this @Udit-takkar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar consumer core area: core, team members only foundation Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2973] Not able to install apple calendar
4 participants