Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in zapier when user has no bookings #14159

Merged
merged 2 commits into from Mar 22, 2024

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Before:
Screenshot 2024-03-20 at 2 44 59 PM

After:
Screenshot 2024-03-20 at 2 44 46 PM

@graphite-app graphite-app bot requested a review from a team March 20, 2024 18:49
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 20, 2024
Copy link

graphite-app bot commented Mar 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 0:41am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 0:41am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 0:41am
qa ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 0:41am

Copy link
Contributor

github-actions bot commented Mar 20, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 383.75 KB 573.32 KB 163.80% (🟡 +0.22%)
/[user]/[type]/embed 383.76 KB 573.32 KB 163.81% (🟡 +0.22%)
/apps 282.12 KB 471.68 KB 134.76% (🟡 +0.23%)
/apps/[slug] 300.08 KB 489.64 KB 139.90% (🟡 +0.23%)
/apps/[slug]/[...pages] 561.28 KB 750.84 KB 214.53% (🟡 +0.23%)
/apps/categories 260.08 KB 449.64 KB 128.47% (🟡 +0.23%)
/apps/categories/[category] 264.38 KB 453.95 KB 129.70% (🟡 +0.23%)
/apps/installed/[category] 284.1 KB 473.67 KB 135.33% (🟡 +0.23%)
/auth/setup 152.94 KB 342.5 KB 97.86% (🟡 +0.23%)
/availability 438.61 KB 628.17 KB 179.48% (🟡 +0.23%)
/bookings/[status] 327.72 KB 517.28 KB 147.80% (🟡 +0.23%)
/d/[link]/[slug] 383.57 KB 573.13 KB 163.75% (🟡 +0.22%)
/enterprise 260.46 KB 450.03 KB 128.58% (🟡 +0.23%)
/event-types 560.06 KB 749.62 KB 214.18% (🟡 +0.23%)
/event-types/[type] 437.28 KB 626.84 KB 179.10% (🟡 +0.23%)
/getting-started/[[...step]] 406.54 KB 596.1 KB 170.31% (🟡 +0.23%)
/insights 479.06 KB 668.63 KB 191.04% (🟡 +0.23%)
/more 259.66 KB 449.22 KB 128.35% (🟡 +0.23%)
/org/[orgSlug]/[user]/[type] 383.96 KB 573.52 KB 163.86% (🟡 +0.22%)
/org/[orgSlug]/[user]/[type]/embed 383.98 KB 573.54 KB 163.87% (🟡 +0.22%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 383.58 KB 573.14 KB 163.76% (🟡 +0.22%)
/org/[orgSlug]/team/[slug]/[type] 383.78 KB 573.34 KB 163.81% (🟡 +0.22%)
/settings/admin 266.51 KB 456.08 KB 130.31% (🟡 +0.23%)
/settings/admin/apps 280.15 KB 469.71 KB 134.20% (🟡 +0.23%)
/settings/admin/apps/[category] 280.13 KB 469.7 KB 134.20% (🟡 +0.23%)
/settings/admin/flags 270.33 KB 459.89 KB 131.40% (🟡 +0.23%)
/settings/admin/impersonation 266.81 KB 456.38 KB 130.39% (🟡 +0.23%)
/settings/admin/oAuth 278.56 KB 468.12 KB 133.75% (🟡 +0.23%)
/settings/admin/oAuth/oAuthView 93.1 KB 282.66 KB 80.76% (🟡 +0.21%)
/settings/admin/orgMigrations/_OrgMigrationLayout 254.76 KB 444.32 KB 126.95% (🟡 +0.23%)
/settings/admin/orgMigrations/moveTeamToOrg 276.18 KB 465.74 KB 133.07% (🟡 +0.23%)
/settings/admin/orgMigrations/moveUserToOrg 295.1 KB 484.66 KB 138.47% (🟡 +0.23%)
/settings/admin/orgMigrations/removeTeamFromOrg 275.94 KB 465.5 KB 133.00% (🟡 +0.23%)
/settings/admin/orgMigrations/removeUserFromOrg 275.95 KB 465.51 KB 133.00% (🟡 +0.23%)
/settings/admin/organizations 268.57 KB 458.13 KB 130.90% (🟡 +0.22%)
/settings/admin/organizations/[id]/edit 267.08 KB 456.64 KB 130.47% (🟡 +0.23%)
/settings/admin/users 269.35 KB 458.91 KB 131.12% (🟡 +0.23%)
/settings/admin/users/[id]/edit 368.94 KB 558.5 KB 159.57% (🟡 +0.23%)
/settings/admin/users/add 368.69 KB 558.25 KB 159.50% (🟡 +0.23%)
/settings/billing 266.72 KB 456.28 KB 130.37% (🟡 +0.23%)
/settings/developer/api-keys 271.19 KB 460.75 KB 131.64% (🟡 +0.23%)
/settings/developer/webhooks 271.24 KB 460.8 KB 131.66% (🟡 +0.23%)
/settings/developer/webhooks/[id] 272.21 KB 461.77 KB 131.93% (🟡 +0.23%)
/settings/developer/webhooks/new 272.25 KB 461.81 KB 131.95% (🟡 +0.22%)
/settings/my-account/appearance 290.73 KB 480.29 KB 137.23% (🟡 +0.23%)
/settings/my-account/calendars 277.97 KB 467.53 KB 133.58% (🟡 +0.23%)
/settings/my-account/conferencing 278.75 KB 468.31 KB 133.80% (🟡 +0.23%)
/settings/my-account/general 355.04 KB 544.6 KB 155.60% (🟡 +0.23%)
/settings/my-account/out-of-office 270.96 KB 460.52 KB 131.58% (🟡 +0.23%)
/settings/my-account/profile 409.07 KB 598.64 KB 171.04% (🟡 +0.23%)
/settings/organizations/[id]/about 153.85 KB 343.41 KB 98.12% (🟡 +0.22%)
/settings/organizations/[id]/add-teams 153.9 KB 343.46 KB 98.13% (🟡 +0.23%)
/settings/organizations/[id]/onboard-members 174.14 KB 363.7 KB 103.91% (🟡 +0.23%)
/settings/organizations/[id]/set-password 153.83 KB 343.39 KB 98.11% (🟡 +0.23%)
/settings/organizations/appearance 290.27 KB 479.83 KB 137.09% (🟡 +0.23%)
/settings/organizations/billing 266.76 KB 456.32 KB 130.38% (🟡 +0.23%)
/settings/organizations/dsync 335.77 KB 525.33 KB 150.10% (🟡 +0.23%)
/settings/organizations/general 354.6 KB 544.16 KB 155.47% (🟡 +0.23%)
/settings/organizations/members 434.82 KB 624.38 KB 178.40% (🟡 +0.22%)
/settings/organizations/new 153.85 KB 343.42 KB 98.12% (🟡 +0.22%)
/settings/organizations/platform/oauth-clients 268.5 KB 458.06 KB 130.87% (🟡 +0.23%)
/settings/organizations/platform/oauth-clients/create 267.9 KB 457.46 KB 130.70% (🟡 +0.23%)
/settings/organizations/privacy 272.11 KB 461.67 KB 131.91% (🟡 +0.23%)
/settings/organizations/profile 400.79 KB 590.36 KB 168.67% (🟡 +0.23%)
/settings/organizations/teams/other 267.59 KB 457.15 KB 130.62% (🟡 +0.22%)
/settings/organizations/teams/other/[id]/appearance 279.3 KB 468.86 KB 133.96% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/members 274.06 KB 463.62 KB 132.46% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/profile 472.09 KB 661.65 KB 189.04% (🟡 +0.23%)
/settings/security/impersonation 271.91 KB 461.47 KB 131.85% (🟡 +0.23%)
/settings/security/password 280.98 KB 470.54 KB 134.44% (🟡 +0.23%)
/settings/security/sso 276.81 KB 466.38 KB 133.25% (🟡 +0.23%)
/settings/security/two-factor-auth 275.72 KB 465.28 KB 132.94% (🟡 +0.23%)
/settings/teams 266.25 KB 455.81 KB 130.23% (🟡 +0.23%)
/settings/teams/[id]/appearance 279.29 KB 468.85 KB 133.96% (🟡 +0.23%)
/settings/teams/[id]/billing 266.76 KB 456.32 KB 130.38% (🟡 +0.23%)
/settings/teams/[id]/members 385.39 KB 574.95 KB 164.27% (🟡 +0.23%)
/settings/teams/[id]/onboard-members 173.32 KB 362.88 KB 103.68% (🟡 +0.23%)
/settings/teams/[id]/profile 472.92 KB 662.48 KB 189.28% (🟡 +0.23%)
/settings/teams/[id]/sso 277.35 KB 466.91 KB 133.40% (🟡 +0.23%)
/settings/teams/new 201.16 KB 390.72 KB 111.64% (🟡 +0.22%)
/team/[slug]/[type] 383.74 KB 573.3 KB 163.80% (🟡 +0.22%)
/team/[slug]/[type]/embed 383.77 KB 573.33 KB 163.81% (🟡 +0.22%)
/teams 259.88 KB 449.45 KB 128.41% (🟡 +0.23%)
/upgrade 260.11 KB 449.67 KB 128.48% (🟡 +0.23%)
/workflows 291.47 KB 481.04 KB 137.44% (🟡 +0.23%)
/workflows/[workflow] 412.23 KB 601.79 KB 171.94% (🟡 +0.23%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Mar 20, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 12 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/22/2024 12:55:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5c51aac

Started: 03/22/2024 12:52:17pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
0% (0) 0 / 181 runs
failed over last 7 days
16.57% (30) 30 / 181 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0% (0) 0 / 183 runs
failed over last 7 days
55.19% (101) 101 / 183 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-123.17% (-101) -101 / 82 runs
failed over last 7 days
123.17% (101) 101 / 82 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-123.17% (-101) -101 / 82 runs
failed over last 7 days
123.17% (101) 101 / 82 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-121.95% (-100) -100 / 82 runs
failed over last 7 days
123.17% (101) 101 / 82 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-124.69% (-101) -101 / 81 runs
failed over last 7 days
124.69% (101) 101 / 81 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-124.69% (-101) -101 / 81 runs
failed over last 7 days
124.69% (101) 101 / 81 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-124.69% (-101) -101 / 81 runs
failed over last 7 days
124.69% (101) 101 / 81 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-124.69% (-101) -101 / 81 runs
failed over last 7 days
124.69% (101) 101 / 81 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
6.32% (12) 12 / 190 runs
failed over last 7 days
27.37% (52) 52 / 190 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 183 runs
failed over last 7 days
31.15% (57) 57 / 183 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.54% (1) 1 / 184 run
failed over last 7 days
38.04% (70) 70 / 184 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only zapier Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants