Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distinguish managed platform users #14207

Merged
merged 6 commits into from Mar 25, 2024
Merged

Conversation

supalarry
Copy link
Contributor

What does this PR do?

Updates User model by adding a new property "isPlatformManaged" marking platform users that have been manually created. It is done so that in the future we can distinguish between platform customers' users created manually and ones who already had cal account.

  1. Update prisma schema with the new property in feat: add isPlatformManaged property to user
  2. Up until now we had CreateUserInput and UpdateUserInput, but I re-name them to CreateManagedPlatformUserInput and UpdateManagedPlatformUserInput to better reflect their purpose in refactor: rename managed user create and update inputs. They are not simple users so they need to be distinguished.
  3. When creating a managed user set "isPlatformManaged" to true in feat: add isPlatformManaged when creating managed user
  4. Do not allow deleting users that have "isPlatformManaged=false" in do not allow deleting non managed users

@graphite-app graphite-app bot requested a review from a team March 25, 2024 17:17
@supalarry supalarry requested review from a team and removed request for a team March 25, 2024 17:17
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the ❗️ migrations contains migration files label Mar 25, 2024
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 25, 2024
Copy link

graphite-app bot commented Mar 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Mar 25, 2024 5:24pm
cal ⬜️ Ignored (Inspect) Mar 25, 2024 5:24pm
calcom-web-canary ⬜️ Ignored (Inspect) Mar 25, 2024 5:24pm
qa ⬜️ Ignored (Inspect) Mar 25, 2024 5:24pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Mar 25, 2024

Current Playwright Test Results Summary

✅ 50 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/25/2024 05:47:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a827d36

Started: 03/25/2024 05:45:55pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
7.35% (15) 15 / 204 runs
failed over last 7 days
25.98% (53) 53 / 204 runs
flaked over last 7 days

View Detailed Build Results


@supalarry supalarry enabled auto-merge (squash) March 25, 2024 17:46
@supalarry supalarry disabled auto-merge March 25, 2024 17:48
@supalarry supalarry merged commit ef498c6 into main Mar 25, 2024
38 of 39 checks passed
@supalarry supalarry deleted the is-platform-managed-user branch March 25, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ❗️ migrations contains migration files platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants