Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EventManager add cancelEvent method #14261

Merged
merged 58 commits into from Apr 23, 2024

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Mar 29, 2024

This PR is stacked on #14147. A part of the CRM refactor

What does this PR do?

This PR adds the cancelEvent method to the EventManager class. Logic surrounding deleting 3rd party data when canceling a booking lived in both handleCancelBooking and the EventManager in a private class.

My hope with this PR is to refactor this so this logic only lives inside of the EventManager

Fixes #14451

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is a UI/UX design document, please, share it here.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Install a calendar and a video integration and enable them on an event type
    • I used GCal and Zoom
  • Create a booking
    • The references should be created in the 3rd party apps
  • Delete the booking
    • The references should be deleted in the 3rd party apps

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Shaik-Sirajuddin and others added 30 commits March 18, 2024 17:12
@joeauyeung joeauyeung enabled auto-merge (squash) April 22, 2024 20:19
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the missing check

@joeauyeung joeauyeung merged commit 571e93a into main Apr 23, 2024
39 of 40 checks passed
@joeauyeung joeauyeung deleted the event-manager-add-cancel-method branch April 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3345] Add cancel method to EventManager
5 participants