Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add classNames prop to Booker atom for passing external styles #14270

Merged
merged 33 commits into from Apr 12, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Mar 30, 2024

What does this PR do?

Currently there's no way to style the booker atom from the oustide. This PR adds a prop called customClassNames through which we can pass in external classnames to customize the styling of the booker

Copy link
Contributor

github-actions bot commented Mar 30, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 30, 2024
@Ryukemeister Ryukemeister changed the title feat: add classnames prop to Booker atom for passing external styles feat: add customClassNames prop to Booker atom for passing external styles Mar 30, 2024
@Ryukemeister Ryukemeister changed the title feat: add customClassNames prop to Booker atom for passing external styles feat: add classNames prop to Booker atom for passing external styles Mar 30, 2024
Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 9:26pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 9:26pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 9:26pm
qa ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 9:26pm
qa-not-in-use ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 9:26pm

Copy link
Contributor

github-actions bot commented Mar 30, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 411.56 KB 639.9 KB 182.83% (🟡 +0.15%)
/[user]/[type]/embed 411.56 KB 639.91 KB 182.83% (🟡 +0.15%)
/d/[link]/[slug] 411.37 KB 639.72 KB 182.78% (🟡 +0.14%)
/org/[orgSlug]/[user]/[type] 411.77 KB 640.11 KB 182.89% (🟡 +0.15%)
/org/[orgSlug]/[user]/[type]/embed 411.79 KB 640.14 KB 182.90% (🟡 +0.14%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 411.38 KB 639.73 KB 182.78% (🟡 +0.15%)
/org/[orgSlug]/team/[slug]/[type] 411.58 KB 639.93 KB 182.84% (🟡 +0.14%)
/team/[slug]/[type] 411.55 KB 639.9 KB 182.83% (🟡 +0.15%)
/team/[slug]/[type]/embed 411.58 KB 639.93 KB 182.84% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Mar 30, 2024

No failed tests 🎉

@Ryukemeister Ryukemeister marked this pull request as ready for review April 12, 2024 09:04
@graphite-app graphite-app bot requested a review from a team April 12, 2024 09:04
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ui area: UI, frontend, button, form, input ✨ feature New feature or request labels Apr 12, 2024
Copy link

graphite-app bot commented Apr 12, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@ThyMinimalDev ThyMinimalDev merged commit c467167 into main Apr 12, 2024
39 checks passed
@ThyMinimalDev ThyMinimalDev deleted the add-custom-classnames-to-booker branch April 12, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants