Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create platform handler isPlatform flag #14288

Merged
merged 9 commits into from Apr 5, 2024

Conversation

supalarry
Copy link
Contributor

We received "isPlatform" property but I forgot to add it to data used to create team.

@graphite-app graphite-app bot requested a review from a team April 2, 2024 11:52
@supalarry supalarry requested review from a team and removed request for a team April 2, 2024 11:52
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 7:15am
cal ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 7:15am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 7:15am
qa ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 7:15am

Copy link

graphite-app bot commented Apr 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

ThyMinimalDev
ThyMinimalDev previously approved these changes Apr 2, 2024
Copy link

deploysentinel bot commented Apr 2, 2024

Current Playwright Test Results Summary

✅ 47 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/05/2024 07:45:32am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b1f11bc

Started: 04/05/2024 07:42:51am UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
7.04% (19) 19 / 270 runs
failed over last 7 days
28.89% (78) 78 / 270 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Inviting an existing user and then create a booking on new link
Retry 1Initial Attempt
0.36% (1) 1 / 279 run
failed over last 7 days
1.79% (5) 5 / 279 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Apr 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

keithwillcode
keithwillcode previously approved these changes Apr 4, 2024
zomars
zomars previously approved these changes Apr 4, 2024
Signed-off-by: zomars <zomars@me.com>

# Conflicts:
#	packages/trpc/server/routers/viewer/organizations/create.handler.ts
@zomars zomars dismissed stale reviews from keithwillcode, ThyMinimalDev, and themself via 386968f April 4, 2024 17:07
zomars
zomars previously approved these changes Apr 4, 2024
@supalarry supalarry merged commit a597def into main Apr 5, 2024
38 checks passed
@supalarry supalarry deleted the fix-create-platform-handler branch April 5, 2024 07:46
},
},
metadata: {
...(IS_TEAM_BILLING_ENABLED ? { requestedSlug: orgData.slug } : {}),
orgSeats: orgData.seats,
orgPricePerSeat: orgData.pricePerSeat,
isPlatform: orgData.isPlatform,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zomars Why was this moved to metadata here? There is a standalone column isPlatform on the team table that the platform team has intended to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants