chore: downgrade react query atoms #14328

supalarry · 2024-04-04T08:48:10Z

One of platform customers uses React 16 while react-query v5 requires at least React 18, so react-query is downgraded to v4.

Only difference is that queries do not return "isPending" but "isLoading", so refactored that in code.

Tested with examples app and it runs.

github-actions · 2024-04-04T08:48:23Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

socket-security · 2024-04-04T08:49:14Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/graphql@16.8.1

View full report↗︎

vercel · 2024-04-04T08:49:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Apr 4, 2024 9:55am
cal	⬜️ Ignored (Inspect)	Visit Preview	Apr 4, 2024 9:55am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Apr 4, 2024 9:55am
qa	⬜️ Ignored (Inspect)	Visit Preview	Apr 4, 2024 9:55am

graphite-app · 2024-04-04T08:50:13Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

sean-brydon

I understand this works and im happy with this downgrade. Lets just make sure for context wise that we are aware isLoading !== isPending

TanStack/query#6297 (comment)

sean-brydon

Also just spotted type check failing in embed still

Looks like there is a use of isPending

supalarry · 2024-04-04T09:11:13Z

Also just spotted type check failing in embed still

Looks like there is a use of isPending

Thanks for checking the PR! Type check now passes!

github-actions · 2024-04-04T09:15:36Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]/[type]`	`413.82 KB`	642 KB	183.43% (🟡 +1.16%)
`/[user]/[type]/embed`	`413.83 KB`	642 KB	183.43% (🟡 +1.16%)
`/availability/[schedule]`	`413.23 KB`	641.41 KB	183.26% (🟡 +1.16%)
`/d/[link]/[slug]`	`413.63 KB`	641.81 KB	183.38% (🟡 +1.16%)
`/org/[orgSlug]/[user]/[type]`	`414.03 KB`	642.21 KB	183.49% (🟡 +1.16%)
`/org/[orgSlug]/[user]/[type]/embed`	`414.05 KB`	642.23 KB	183.50% (🟡 +1.16%)
`/org/[orgSlug]/instant-meeting/team/[slug]/[type]`	`413.65 KB`	641.83 KB	183.38% (🟡 +1.16%)
`/org/[orgSlug]/team/[slug]/[type]`	`413.84 KB`	642.02 KB	183.43% (🟡 +1.17%)
`/team/[slug]/[type]`	`413.81 KB`	641.99 KB	183.43% (🟡 +1.16%)
`/team/[slug]/[type]/embed`	`413.84 KB`	642.02 KB	183.43% (🟡 +1.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2024-04-04T09:15:55Z

Current Playwright Test Results Summary

✅ 300 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/04/2024 10:07:51am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0ff2893

Started: 04/04/2024 10:03:42am UTC

⚠️ Flakes

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 1 • Initial Attempt	6.50% (13) 13 / 200 runs failed over last 7 days	28.50% (57) 57 / 200 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 1 • Initial Attempt	6.19% (13) 13 / 210 runs failed over last 7 days	33.33% (70) 70 / 210 runs flaked over last 7 days
Stripe integration Pending payment booking should not be confirmed by default Retry 1 • Initial Attempt	1.51% (3) 3 / 199 runs failed over last 7 days	18.09% (36) 36 / 199 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work Retry 1 • Initial Attempt	1% (2) 2 / 200 runs failed over last 7 days	13.50% (27) 27 / 200 runs flaked over last 7 days
Routing Forms Seeded Routing Form Test preview should return correct route Retry 1 • Initial Attempt	0% (0) 0 / 199 runs failed over last 7 days	13.57% (27) 27 / 199 runs flaked over last 7 days

📄 apps/web/playwright/team/team-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Team Invitation (non verified) Retry 1 • Initial Attempt	0% (0) 0 / 205 runs failed over last 7 days	6.83% (14) 14 / 205 runs flaked over last 7 days

📄 apps/web/playwright/settings-admin.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Settings/admin tests -- future should render /settings/admin page Retry 1 • Initial Attempt	2.37% (5) 5 / 211 runs failed over last 7 days	0.95% (2) 2 / 211 runs flaked over last 7 days

View Detailed Build Results

sean-brydon

LGTM! Thanks for making them changes - Lets keep an eye out to see if we see anything un expected with using isLoading > isPending

This reverts commit 8fc9b9a.

supalarry added 4 commits April 4, 2024 09:50

refactor: downgrade atoms react-query to v4

bd549fd

driveby: prettier format file

ed8819b

refactor: react-query isPending to isLoading

673cc2f

chore: bump atoms version

bb0d47b

graphite-app bot requested review from a team April 4, 2024 08:48

dosubot bot added core area: core, team members only platform Anything related to our platform plan ⬆️ dependencies Pull requests that update a dependency file 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 4, 2024

graphite-app bot requested a review from a team April 4, 2024 08:48

vercel bot deployed to Preview – ai April 4, 2024 08:49 View deployment

sean-brydon reviewed Apr 4, 2024

View reviewed changes

vercel bot deployed to Preview – api April 4, 2024 08:54 View deployment

sean-brydon requested changes Apr 4, 2024

View reviewed changes

refactor: isPending -> isLoading

86e41a7

supalarry requested a review from sean-brydon April 4, 2024 09:11

vercel bot deployed to Preview – api April 4, 2024 09:13 View deployment

chore: bump version

9a58a13

vercel bot deployed to Preview – api April 4, 2024 09:31 View deployment

Merge branch 'main' into downgrade-react-query-atoms

dbae6a0

vercel bot deployed to Preview – api April 4, 2024 09:52 View deployment

Merge branch 'main' into downgrade-react-query-atoms

0ff2893

vercel bot deployed to Preview – api April 4, 2024 09:59 View deployment

vercel bot deployed to Preview – dev April 4, 2024 10:16 View deployment

sean-brydon approved these changes Apr 4, 2024

View reviewed changes

sean-brydon merged commit 8fc9b9a into main Apr 4, 2024
37 checks passed

sean-brydon deleted the downgrade-react-query-atoms branch April 4, 2024 10:28

supalarry added a commit that referenced this pull request Apr 4, 2024

Revert "chore: downgrade react query atoms (#14328)"

cf11fc9

This reverts commit 8fc9b9a.

supalarry mentioned this pull request Apr 4, 2024

revert: chore downgrade react query atoms #14332

Merged

supalarry added a commit that referenced this pull request Apr 4, 2024

Revert "chore: downgrade react query atoms (#14328)" (#14332)

d7ece4f

This reverts commit 8fc9b9a.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: downgrade react query atoms #14328

chore: downgrade react query atoms #14328

supalarry commented Apr 4, 2024

github-actions bot commented Apr 4, 2024 •

edited

Loading

socket-security bot commented Apr 4, 2024 •

edited

Loading

vercel bot commented Apr 4, 2024 •

edited

Loading

graphite-app bot commented Apr 4, 2024

sean-brydon left a comment

sean-brydon left a comment

supalarry commented Apr 4, 2024

github-actions bot commented Apr 4, 2024 •

edited

Loading

deploysentinel bot commented Apr 4, 2024 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

sean-brydon left a comment

chore: downgrade react query atoms #14328

chore: downgrade react query atoms #14328

Conversation

supalarry commented Apr 4, 2024

github-actions bot commented Apr 4, 2024 • edited Loading

socket-security bot commented Apr 4, 2024 • edited Loading

vercel bot commented Apr 4, 2024 • edited Loading

graphite-app bot commented Apr 4, 2024

Graphite Automations

sean-brydon left a comment

Choose a reason for hiding this comment

sean-brydon left a comment

Choose a reason for hiding this comment

supalarry commented Apr 4, 2024

github-actions bot commented Apr 4, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

Ten Pages Changed Size

deploysentinel bot commented Apr 4, 2024 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

sean-brydon left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 4, 2024 •

edited

Loading

socket-security bot commented Apr 4, 2024 •

edited

Loading

vercel bot commented Apr 4, 2024 •

edited

Loading

github-actions bot commented Apr 4, 2024 •

edited

Loading

deploysentinel bot commented Apr 4, 2024 •

edited

Loading