New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: always show intercom on desktop by default (hidden on mobile) #14423
feat: always show intercom on desktop by default (hidden on mobile) #14423
Conversation
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Sixty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/05/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (04/05/24)1 label was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/05/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! haven't tested
Will this affect hosters that don't have intercom enabled? |
uhm. it depends how it was implemented. i think if its wrapped in env && then no, @SomayChauhan any ideas? the previous implementation worked without selfhosters having intercom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and useIntercom already handles if enabled for self hosters. My only concern is the sudden change of behavior if a self hoster has intercom enabled.
What does this PR do?
Fixes #14043,
Fixes CAL-3361
https://www.loom.com/share/27a2fad8d12e43ca92d2b95293d93f62?sid=d4e3b466-409a-4aa7-aa0f-a06acd3a20ab