Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always show intercom on desktop by default (hidden on mobile) #14423

Merged
merged 11 commits into from Apr 11, 2024

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Apr 5, 2024

Copy link

vercel bot commented Apr 5, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 277.7 KB 506.34 KB 144.67% (🟡 +0.20%)
/apps/[slug]/[...pages] 585.08 KB 813.72 KB 232.49% (🟡 +0.22%)
/apps/categories 254.62 KB 483.26 KB 138.08% (🟡 +0.23%)
/availability 462.49 KB 691.14 KB 197.47% (🟡 +0.23%)
/availability/[schedule] 408.62 KB 637.27 KB 182.08% (🟡 +0.23%)
/bookings/[status] 322.37 KB 551.01 KB 157.43% (🟡 +0.24%)
/enterprise 254.68 KB 483.32 KB 138.09% (🟡 +0.24%)
/event-types 554.19 KB 782.84 KB 223.67% (🟡 +0.17%)
/event-types/[type] 433.34 KB 661.98 KB 189.14% (🟡 +0.21%)
/getting-started/[[...step]] 404.37 KB 633.02 KB 180.86% (🟢 -0.31%)
/insights 473.08 KB 701.73 KB 200.49% (🟡 +0.24%)
/more 254.18 KB 482.83 KB 137.95% (🟡 +0.24%)
/settings/admin 260.5 KB 489.14 KB 139.75% (🟡 +0.24%)
/settings/admin/apps 273.56 KB 502.21 KB 143.49% (🟡 +0.23%)
/settings/admin/apps/[category] 273.55 KB 502.19 KB 143.48% (🟡 +0.24%)
/settings/admin/flags 264.29 KB 492.94 KB 140.84% (🟡 +0.23%)
/settings/admin/impersonation 260.79 KB 489.44 KB 139.84% (🟡 +0.23%)
/settings/admin/oAuth 272.5 KB 501.15 KB 143.18% (🟡 +0.24%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.08 KB 477.73 KB 136.49% (🟡 +0.24%)
/settings/admin/orgMigrations/moveTeamToOrg 298.57 KB 527.21 KB 150.63% (🟡 +0.24%)
/settings/admin/orgMigrations/moveUserToOrg 317.73 KB 546.38 KB 156.11% (🟡 +0.23%)
/settings/admin/orgMigrations/removeTeamFromOrg 298.33 KB 526.97 KB 150.56% (🟡 +0.24%)
/settings/admin/orgMigrations/removeUserFromOrg 298.34 KB 526.99 KB 150.57% (🟡 +0.23%)
/settings/admin/organizations 262.37 KB 491.02 KB 140.29% (🟡 +0.24%)
/settings/admin/organizations/[id]/edit 261.04 KB 489.69 KB 139.91% (🟡 +0.24%)
/settings/admin/users 263.14 KB 491.78 KB 140.51% (🟡 +0.23%)
/settings/admin/users/[id]/edit 391.39 KB 620.04 KB 177.15% (🟡 +0.24%)
/settings/admin/users/add 391.06 KB 619.71 KB 177.06% (🟡 +0.23%)
/settings/billing 260.7 KB 489.34 KB 139.81% (🟡 +0.24%)
/settings/developer/api-keys 265.07 KB 493.71 KB 141.06% (🟡 +0.24%)
/settings/developer/webhooks 265.2 KB 493.84 KB 141.10% (🟡 +0.23%)
/settings/my-account/appearance 313.07 KB 541.71 KB 154.78% (🟡 +0.23%)
/settings/my-account/general 348.61 KB 577.26 KB 164.93% (🟡 +0.24%)
/settings/my-account/out-of-office 265.68 KB 494.33 KB 141.24% (🟡 +0.23%)
/settings/my-account/profile 403.86 KB 632.51 KB 180.72% (🟡 +0.23%)
/settings/organizations/appearance 284.22 KB 512.86 KB 146.53% (🟡 +0.24%)
/settings/organizations/billing 260.73 KB 489.38 KB 139.82% (🟡 +0.24%)
/settings/organizations/dsync 330.85 KB 559.5 KB 159.86% (🟡 +0.23%)
/settings/organizations/general 348.6 KB 577.24 KB 164.93% (🟡 +0.23%)
/settings/organizations/members 429.35 KB 658 KB 188.00% (🟡 +0.23%)
/settings/organizations/platform/oauth-clients 262.53 KB 491.18 KB 140.34% (🟡 +0.23%)
/settings/organizations/platform/oauth-clients/create 262.09 KB 490.74 KB 140.21% (🟡 +0.24%)
/settings/organizations/privacy 266.08 KB 494.73 KB 141.35% (🟡 +0.24%)
/settings/organizations/profile 395.37 KB 624.02 KB 178.29% (🟡 +0.24%)
/settings/organizations/sso 271.35 KB 499.99 KB 142.85% (🟡 +0.24%)
/settings/organizations/teams/other 261.56 KB 490.21 KB 140.06% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/appearance 273.23 KB 501.87 KB 143.39% (🟡 +0.24%)
/settings/organizations/teams/other/[id]/members 268.03 KB 496.68 KB 141.91% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/profile 466.98 KB 695.63 KB 198.75% (🟡 +0.24%)
/settings/security/impersonation 265.88 KB 494.52 KB 141.29% (🟡 +0.24%)
/settings/security/password 303.44 KB 532.08 KB 152.02% (🟡 +0.24%)
/settings/security/sso 270.75 KB 499.39 KB 142.68% (🟡 +0.24%)
/settings/security/two-factor-auth 269.34 KB 497.99 KB 142.28% (🟡 +0.24%)
/settings/teams 260.23 KB 488.88 KB 139.68% (🟡 +0.23%)
/settings/teams/[id]/appearance 273.21 KB 501.86 KB 143.39% (🟡 +0.23%)
/settings/teams/[id]/billing 260.73 KB 489.38 KB 139.82% (🟡 +0.24%)
/settings/teams/[id]/members 379.98 KB 608.63 KB 173.89% (🟡 +0.24%)
/settings/teams/[id]/profile 467.83 KB 696.48 KB 198.99% (🟡 +0.24%)
/teams 254.41 KB 483.05 KB 138.02% (🟡 +0.23%)
/upgrade 254.53 KB 483.17 KB 138.05% (🟡 +0.23%)
/workflows 285.66 KB 514.3 KB 146.94% (🟡 +0.22%)
/workflows/[workflow] 407.85 KB 636.49 KB 181.85% (🟡 +0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions github-actions bot added the ❗️ migrations contains migration files label Apr 5, 2024
@SomayChauhan SomayChauhan marked this pull request as ready for review April 5, 2024 17:50
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 5, 2024
@graphite-app graphite-app bot requested a review from a team April 5, 2024 17:50
@dosubot dosubot bot added core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan labels Apr 5, 2024
@graphite-app graphite-app bot requested a review from a team April 5, 2024 17:50
Copy link

graphite-app bot commented Apr 5, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/05/24)

1 label was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@PeerRich PeerRich removed the community Created by Linear-GitHub Sync label Apr 8, 2024
@PeerRich PeerRich added this to the v4.0 milestone Apr 8, 2024
packages/prisma/schema.prisma Outdated Show resolved Hide resolved
@PeerRich PeerRich removed the request for review from a team April 8, 2024 16:49
@github-actions github-actions bot added the community Created by Linear-GitHub Sync label Apr 9, 2024
@PeerRich PeerRich removed the ❗️ migrations contains migration files label Apr 11, 2024
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! haven't tested

@PeerRich PeerRich enabled auto-merge (squash) April 11, 2024 16:07
@zomars
Copy link
Member

zomars commented Apr 11, 2024

Will this affect hosters that don't have intercom enabled?

@PeerRich
Copy link
Member

Will this affect hosters that don't have intercom enabled?

uhm. it depends how it was implemented. i think if its wrapped in env && then no, @SomayChauhan any ideas?

the previous implementation worked without selfhosters having intercom

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and useIntercom already handles if enabled for self hosters. My only concern is the sudden change of behavior if a self hoster has intercom enabled.

@PeerRich PeerRich merged commit f010279 into calcom:main Apr 11, 2024
30 of 38 checks passed
@dosubot dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync core area: core, team members only event-types area: event types, event-types ✨ feature New feature or request linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3361] always show intercom on desktop by default (hidden on mobile)
3 participants