Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Team Invite Email Text formatting #14434

Merged
merged 3 commits into from Apr 8, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Apr 6, 2024

What does this PR do?

Fixes #14435
Regression from #13139

Before New Org Onboarding Schema
image

Current Production
image

This PR
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Simply invite a new or existing user of an org to a team

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 10:14am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 10:14am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 10:14am
qa ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 10:14am

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 6, 2024
@hariombalhara hariombalhara added the 📉 regressing This used to work. Now it doesn't anymore. label Apr 6, 2024
@hariombalhara hariombalhara changed the title fix: Team Invite Email Text fix: Team Invite Email Text formatting Apr 6, 2024
@hariombalhara hariombalhara added this to the v4.0 milestone Apr 6, 2024
@@ -227,19 +227,17 @@ export const TeamInviteEmail = (
if (typeOfInvite === "TO_SUBTEAM") {
return (
<>
(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was in JS land but it was in JSX 😅

@hariombalhara hariombalhara marked this pull request as ready for review April 6, 2024 09:40
@graphite-app graphite-app bot requested a review from a team April 6, 2024 09:40
@dosubot dosubot bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Apr 6, 2024
Copy link

graphite-app bot commented Apr 6, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 6, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 6, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 14 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/08/2024 10:14:07am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 2e1cade

Started: 04/08/2024 10:10:51am UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
7.07% (21) 21 / 297 runs
failed over last 7 days
27.61% (82) 82 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
6.78% (20) 20 / 295 runs
failed over last 7 days
20% (59) 59 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0% (0) 0 / 287 runs
failed over last 7 days
12.54% (36) 36 / 287 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
4.70% (14) 14 / 298 runs
failed over last 7 days
33.22% (99) 99 / 298 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0% (0) 0 / 288 runs
failed over last 7 days
59.03% (170) 170 / 288 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-143.22% (-169) -169 / 118 runs
failed over last 7 days
143.22% (169) 169 / 118 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-142.37% (-168) -168 / 118 runs
failed over last 7 days
142.37% (168) 168 / 118 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 290 runs
failed over last 7 days
35.17% (102) 102 / 290 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0% (0) 0 / 290 runs
failed over last 7 days
53.79% (156) 156 / 290 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara merged commit 6390d59 into main Apr 8, 2024
39 of 40 checks passed
@hariombalhara hariombalhara deleted the 04-06-fix_team_invite_email_text branch April 8, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email 📉 regressing This used to work. Now it doesn't anymore. teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3364] Team Invite Email weird formatting
4 participants