Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty "Add guests" email input is blocking form submission #14442

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: Empty "Add guests" email input is blocking form submission #14442

merged 2 commits into from
Apr 8, 2024

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Fixes #14441

Screen.Recording.2024-04-07.at.5.01.01.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel Vercel
Copy link

vercel bot commented Apr 7, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 7, 2024
@graphite-app graphite-app bot requested a review from a team April 7, 2024 11:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking core area: core, team members only ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Apr 7, 2024
@github-actions github-actions bot added booking-page area: booking page, public booking page, booker Urgent Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 7, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/07/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

emrysal
emrysal approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@emrysal emrysal enabled auto-merge (squash) April 8, 2024 13:05
@emrysal emrysal merged commit 260521f into calcom:main Apr 8, 2024
31 of 39 checks passed
@dosubot dosubot bot modified the milestones: v4.1, v4.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ui area: UI, frontend, button, form, input Urgent Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-3365] Booking form: Empty "Add guests" email input is blocking form submission
2 participants
@Amit91848 @emrysal