Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): missing string literal opening #14463

Merged
merged 3 commits into from Apr 10, 2024
Merged

Conversation

johnforte
Copy link
Contributor

What does this PR do?

This fixes an issue where the title is not rendered correctly and shows the code and not the translated string output.

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is a UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Go to https://app.cal.com/availability/ and check tab title to make sure it is correctly rendering.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Apr 8, 2024

@johnforte is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 8, 2024
@graphite-app graphite-app bot requested a review from a team April 8, 2024 20:22
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 8, 2024
@graphite-app graphite-app bot requested a review from a team April 8, 2024 20:22
Copy link

graphite-app bot commented Apr 8, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/08/24)

1 label was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v4.0 milestone Apr 9, 2024
Copy link
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@CarinaWolli CarinaWolli merged commit e30b41a into calcom:main Apr 10, 2024
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants