feat: In Embed, Fire 'routed' event when Routing Form routes #14470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
hariombalhara
changed the title
hariombalhara
changed the title
dosubot
bot
added
embed
Current Playwright Test Results Summary✅ 48 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/11/2024 03:38:30am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b640e45 Started: 04/11/2024 03:35:15am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
5.57% (16)16 / 287 runsfailed over last 7 days |
23.69% (68)68 / 287 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sean-brydon
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14469
Loom Demo
This is how one can listen to the event.
https://github.com/calcom/cal.com/blob/04-09-add_routed_event/packages/embeds/embed-core/playground.ts#L374
If no, namespace is being used. The API simply becomes Cal('on')
Type of change
How should this be tested?
See Loom
Mandatory Tasks
Checklist