Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove exports in barrel file which are causing prisma import on client side #14475

Merged
merged 1 commit into from Apr 9, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Apr 9, 2024

There are className imports on client side which is imported from @calcom/lib/index file which was importing getEventTypesByViewer file which imports repository which then imports prisma.

className -> @calcom/lib/index -> getEventTypesByViewer -> repository/event-type -> prisma

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:11am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Apr 9, 2024 0:11am
calcom-web-canary ⬜️ Ignored (Inspect) Apr 9, 2024 0:11am
qa ⬜️ Ignored (Inspect) Apr 9, 2024 0:11am

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 9, 2024
@hariombalhara hariombalhara changed the title fix: Remove unnecessary export in barrel file which is causing prisma import on client side fix: Remove unnecessary exports in barrel file which is causing prisma import on client side Apr 9, 2024
@hariombalhara hariombalhara changed the title fix: Remove unnecessary exports in barrel file which is causing prisma import on client side fix: Remove exports in barrel file which are causing prisma import on client side Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 9, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 16 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/09/2024 12:23:45pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c296826

Started: 04/09/2024 12:20:14pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present
Retry 1Initial Attempt
0% (0) 0 / 309 runs
failed over last 7 days
1.94% (6) 6 / 309 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
8.13% (26) 26 / 320 runs
failed over last 7 days
22.19% (71) 71 / 320 runs
flaked over last 7 days
Teams - NonOrg -- future Email Embeds slots are loading for team event types
Retry 1Initial Attempt
2.81% (9) 9 / 320 runs
failed over last 7 days
1.25% (4) 4 / 320 runs
flaked over last 7 days
Teams - NonOrg -- legacy Team Onboarding Invite Members
Retry 1Initial Attempt
0% (0) 0 / 319 runs
failed over last 7 days
0.31% (1) 1 / 319 run
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- future Time slots should be reserved when selected
Retry 1Initial Attempt
0.32% (1) 1 / 312 run
failed over last 7 days
7.37% (23) 23 / 312 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0.32% (1) 1 / 312 run
failed over last 7 days
61.54% (192) 192 / 312 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-160.50% (-191) -191 / 119 runs
failed over last 7 days
160.50% (191) 191 / 119 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-159.66% (-190) -190 / 119 runs
failed over last 7 days
159.66% (190) 190 / 119 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-158.82% (-189) -189 / 119 runs
failed over last 7 days
159.66% (190) 190 / 119 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-161.02% (-190) -190 / 118 runs
failed over last 7 days
161.02% (190) 190 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-161.02% (-190) -190 / 118 runs
failed over last 7 days
161.02% (190) 190 / 118 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-161.02% (-190) -190 / 118 runs
failed over last 7 days
161.02% (190) 190 / 118 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-161.02% (-190) -190 / 118 runs
failed over last 7 days
161.02% (190) 190 / 118 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Inviting an existing user and then create a booking on new link
Retry 1Initial Attempt
0% (0) 0 / 326 runs
failed over last 7 days
2.15% (7) 7 / 326 runs
flaked over last 7 days

📄   apps/web/playwright/onboarding.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Onboarding Onboarding v2 Onboarding Flow
Retry 1Initial Attempt
2.65% (9) 9 / 339 runs
failed over last 7 days
0.29% (1) 1 / 339 run
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.64% (2) 2 / 313 runs
failed over last 7 days
51.44% (161) 161 / 313 runs
flaked over last 7 days

View Detailed Build Results


@JeroenReumkens
Copy link
Contributor

Had this issue in website repo, and can confirm this fix fixes that issue.

CleanShot 2024-04-09 at 16 58 13@2x

@keithwillcode keithwillcode marked this pull request as ready for review April 9, 2024 18:36
@graphite-app graphite-app bot requested a review from a team April 9, 2024 18:37
@dosubot dosubot bot added platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 9, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) April 9, 2024 18:37
@keithwillcode keithwillcode merged commit 46a1713 into main Apr 9, 2024
45 checks passed
@keithwillcode keithwillcode deleted the remove-unncessary-export branch April 9, 2024 18:37
keithwillcode pushed a commit that referenced this pull request Apr 9, 2024
Copy link

graphite-app bot commented Apr 9, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants