Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure the session is invalidated during booking-seats test #14478

Merged
merged 1 commit into from Apr 9, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Apr 9, 2024

What does this PR do?

Fixes test fail on localhost due to the session user not being immediately invalidated, therefore still seeing isHost = true and seeing all attendee information.

@graphite-app graphite-app bot requested a review from a team April 9, 2024 12:48
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright core area: core, team members only platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@graphite-app graphite-app bot requested a review from a team April 9, 2024 12:49
Copy link

graphite-app bot commented Apr 9, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Apr 9, 2024 0:50am

@emrysal emrysal removed the platform Anything related to our platform plan label Apr 9, 2024
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! I'd have thought we redirect from auth/logout but i guess it makes sense

@keithwillcode keithwillcode enabled auto-merge (squash) April 9, 2024 13:00
Copy link

deploysentinel bot commented Apr 9, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/09/2024 01:04:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3598950

Started: 04/09/2024 01:00:07pm UTC

⚠️ Flakes

📄   apps/web/playwright/insights.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should be able to go to insights as admins
Retry 1Initial Attempt
0% (0) 0 / 311 runs
failed over last 7 days
3.86% (12) 12 / 311 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 315 runs
failed over last 7 days
6.35% (20) 20 / 315 runs
flaked over last 7 days
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 312 runs
failed over last 7 days
5.45% (17) 17 / 312 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
8.05% (26) 26 / 323 runs
failed over last 7 days
22.29% (72) 72 / 323 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting user form, triggers user webhook
Retry 1Initial Attempt
0% (0) 0 / 318 runs
failed over last 7 days
2.83% (9) 9 / 318 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 315 runs
failed over last 7 days
33.65% (106) 106 / 315 runs
flaked over last 7 days

📄   apps/web/playwright/organization/team-management.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Can create teams via Wizard
Retry 1Initial Attempt
0% (0) 0 / 327 runs
failed over last 7 days
0.92% (3) 3 / 327 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.63% (2) 2 / 315 runs
failed over last 7 days
51.75% (163) 163 / 315 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

github-actions bot commented Apr 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode merged commit be31100 into main Apr 9, 2024
39 of 40 checks passed
@keithwillcode keithwillcode deleted the bugfix/session-not-invalidated-immediately branch April 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working core area: core, team members only foundation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants