fix: add new styling for emoji links #14481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/17/2024 12:29:15pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: c6ccbfa Started: 04/17/2024 12:25:39pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
1.07% (3)3 / 281 runsfailed over last 7 days |
12.81% (36)36 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user can add multiple organizer address
Retry 1 • Initial Attempt |
0.71% (2)2 / 283 runsfailed over last 7 days |
15.55% (44)44 / 283 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.36% (1)1 / 278 runfailed over last 7 days |
37.05% (103)103 / 278 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
1.08% (3)3 / 277 runsfailed over last 7 days |
21.66% (60)60 / 277 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
-0.36% (-1)-1 / 276 runsfailed over last 7 days |
63.77% (176)176 / 276 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-176% (-176)-176 / 100 runsfailed over last 7 days |
176% (176)176 / 100 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-176% (-176)-176 / 100 runsfailed over last 7 days |
176% (176)176 / 100 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-174% (-174)-174 / 100 runsfailed over last 7 days |
175% (175)175 / 100 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-176.77% (-175)-175 / 99 runsfailed over last 7 days |
176.77% (175)175 / 99 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-176.77% (-175)-175 / 99 runsfailed over last 7 days |
176.77% (175)175 / 99 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-176.77% (-175)-175 / 99 runsfailed over last 7 days |
176.77% (175)175 / 99 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-176.77% (-175)-175 / 99 runsfailed over last 7 days |
176.77% (175)175 / 99 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.36% (1)1 / 280 runfailed over last 7 days |
53.57% (150)150 / 280 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
0.34% (1)1 / 291 runfailed over last 7 days |
4.47% (13)13 / 291 runsflaked over last 7 days |
CarinaWolli
commented
Apr 9, 2024
| // Select all <a> tags inside <h6> elements --> only used for emojis in rating template | ||
| const links = document.querySelectorAll("h6 a"); | ||
|
|
||
| links.forEach((link) => { |
There was a problem hiding this comment.
add inline styles for emojis (h6 links)
| @@ -67,6 +72,7 @@ | |||
|
|
|||
| .editor-paragraph { | |||
| margin: 0; | |||
| margin-top:14px; | |||
There was a problem hiding this comment.
same as
behaves in email
| @@ -56,9 +52,18 @@ | |||
| font-style: italic; | |||
| } | |||
|
|
|||
| // h6 is only used for emoji links | |||
| .editor-heading-h6 { | |||
There was a problem hiding this comment.
Not sure why I need this, but if I remove it then the styles for h6 a from below are not applied
There was a problem hiding this comment.
Yeah seems like an issue in editor's end really.
CarinaWolli
changed the title
CarinaWolli
commented
Apr 9, 2024
| @@ -376,7 +376,12 @@ export default function ToolbarPlugin(props: TextEditorProps) { | |||
| editor.registerUpdateListener(({ editorState, prevEditorState }) => { | |||
| editorState.read(() => { | |||
| const textInHtml = $generateHtmlFromNodes(editor).replace(/</g, "<").replace(/>/g, ">"); | |||
| props.setText(textInHtml); | |||
| props.setText( | |||
There was a problem hiding this comment.
Enter results in <p class="editor-paragraph"><br></p> which is the paragraph margin and a new line. We only want the margin.
Multiple enter in a row don't work as expected in the email, but for this case shift-enter can be used. Wasn't able to figure out a fix for this yet
|
Can we also address this in this PR? |
PeerRich
approved these changes
Apr 17, 2024
dosubot
bot
added
ui
PeerRich
approved these changes
Apr 17, 2024
|
Let's address the following as follow up |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After:
Before:
After:
Before: